linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kronos <kronos@people.it>
To: "Antonino A. Daplas" <adaplas@hotpop.com>
Cc: linux-fbdev-devel@lists.sourceforge.net,
	Andrew Morton <akpm@osdl.org>,
	Marcelo Tosatti <marcelo.tosatti@cyclades.com>
Subject: Re: Re: 2.6.8.1-mm2
Date: Fri, 20 Aug 2004 18:20:45 +0200	[thread overview]
Message-ID: <20040820162045.GB5184@dreamland.darkstar.lan> (raw)
In-Reply-To: <200408201711.26091.adaplas@hotpop.com>

Il Fri, Aug 20, 2004 at 05:11:26PM +0800, Antonino A. Daplas ha scritto: 
> > > drivers/built-in.o(.text+0xa1bde): In function `radeon_match_mode':
> > > : undefined reference to `vesa_modes'
> > >
> > > drivers/built-in.o(.text+0xa1cbd): In function `radeon_match_mode':
> > > : undefined reference to `vesa_modes'
> > >
> > > make: ** [.tmp_vmlinux1] Erro 1
> > >
> > > Known already?
> >
> > nope.  That symbol is exported to modules.
> >
> 
> Oops.  vesa_modes is now dependent on CONFIG_FB_MODE_HELPERS.  
> I'll submit a patch over the weekend to fix drivers that require this option.
> 
> Tony

Hi,
I sent the following patch a while ago. radeonfb, rivafb and i810fb need
CONFIG_FB_MODE_HELPERS the patch makes them select it: 

--- a/drivers/video/Kconfig	2004-08-09 17:03:58.000000000 +0200
+++ b/drivers/video/Kconfig	2004-08-09 17:04:56.000000000 +0200
@@ -437,6 +437,7 @@
 	depends on FB && PCI
 	select I2C_ALGOBIT if FB_RIVA_I2C
 	select I2C if FB_RIVA_I2C
+	select FB_MODE_HELPERS
 	help
 	  This driver supports graphics boards with the nVidia Riva/Geforce
 	  chips.
@@ -469,6 +470,7 @@
 config FB_I810
 	tristate "Intel 810/815 support (EXPERIMENTAL)"
 	depends on FB && AGP && AGP_INTEL && EXPERIMENTAL && PCI	
+	select FB_MODE_HELPERS
 	help
 	  This driver supports the on-board graphics built in to the Intel 810 
           and 815 chipsets.  Say Y if you have and plan to use such a board.
@@ -672,6 +674,7 @@
 	depends on FB && PCI
 	select I2C_ALGOBIT if FB_RADEON_I2C
 	select I2C if FB_RADEON_I2C
+	select FB_MODE_HELPERS
 	help
 	  Choose this option if you want to use an ATI Radeon graphics card as
 	  a framebuffer device.  There are both PCI and AGP versions.  You


Luca
-- 
Home: http://kronoz.cjb.net
Do, or do not. There is no try.


-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

      reply	other threads:[~2004-08-20 16:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20040819014204.2d412e9b.akpm@osdl.org>
     [not found] ` <20040820005019.GB6374@logos.cnet>
2004-08-20  6:08   ` 2.6.8.1-mm2 Andrew Morton
2004-08-20  9:11     ` 2.6.8.1-mm2 Antonino A. Daplas
2004-08-20 16:20       ` Kronos [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040820162045.GB5184@dreamland.darkstar.lan \
    --to=kronos@people.it \
    --cc=adaplas@hotpop.com \
    --cc=akpm@osdl.org \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    --cc=marcelo.tosatti@cyclades.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).