From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Antonino A. Daplas" <adaplas@hotpop.com>
Subject: Re: [Linux-fbdev-devel] [PATCH 4/5][RFC] fbdev: Clean up framebuffer initialization
Date: Sun, 5 Sep 2004 18:40:10 +0800
Sender: linux-kernel-owner@vger.kernel.org
Message-ID: <200409051840.10202.adaplas@hotpop.com>
References: <200409041108.40276.adaplas@hotpop.com> <200409051750.47987.adaplas@hotpop.com> <Pine.GSO.4.58.0409051206180.28961@waterleaf.sonytel.be>
Reply-To: adaplas@pol.net
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Return-path: <linux-kernel-owner+glk-linux-kernel=40m.gmane.org-S266289AbUIEKkA@vger.kernel.org>
In-Reply-To: <Pine.GSO.4.58.0409051206180.28961@waterleaf.sonytel.be>
Content-Disposition: inline
List-Id: <fbdev-devel.lists.sourceforge.net
Content-Type: text/plain; charset="us-ascii"
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux Frame Buffer Device Development <linux-fbdev-devel@lists.sourceforge.net>, Andrew Morton <akpm@osdl.org>, Linux Kernel Development <linux-kernel@vger.kernel.org>, Thomas Winischhofer <thomas@winischhofer.net>

On Sunday 05 September 2004 18:13, Geert Uytterhoeven wrote:
> On Sun, 5 Sep 2004, Antonino A. Daplas wrote:
> > On Sunday 05 September 2004 17:16, Geert Uytterhoeven wrote:
> > > On Sat, 4 Sep 2004, Antonino A. Daplas wrote:
> > > > Currently, the framebuffer system is initialized in a roundabout
> > > > manner. First, drivers/char/mem.c calls fbmem_init().  fbmem_init()
> > > > will then iterate over an array of individual drivers' xxxfb_init(),
> > > > then each driver registers its presence back to fbmem.  During
> > > > console_init(), drivers/char/vt.c will call fb_console_init(). fbcon
> > > > will check for registered drivers, and if any are present, will call
> > > > take_over_console() in drivers/char/vt.c.
> > > >
> > > > This patch changes the initialization sequence so it proceeds in this
> > > > manner: Each driver has its own module_init(). Each driver calls
> > > > register_framebuffer() in fbmem.c. fbmem.c will then notify fbcon of
> > > > the driver registration.  Upon notification, fbcon calls
> > > > take_over_console() in vt.c.
> > >
> > > My main concern with this change is that it will be no longer possible
> > > to change initialization order (and hence choose the primary display
> > > for systems with multiple graphics adapters) by specifying
> > > `video=xxxfb' on the kernel command line.
> >
> > I see your point.  But, can we use "fbcon=" setup options to choose which
> > fb gets mapped to what console? We already have fbcon=map:<option> so we
> > can choose which becomes the primary display. Granted the "fbcon=" setup
> > is currently broken, but if fixed, will that be a fair compromise?
>
> Yes, sounds fine.

Thanks.

>
> Just thinking of something else: right now it's possible to disable a fbdev
> by saying `video=xxxfb:off'. This can be useful if the fbdev driver doesn't
> work with your hardware. After you change, individual fbdev drivers will
> have to reimplement this theirselves in their __setup() functions.

Yes.  I hope this doesn't bite too deep.  If it does, I think we can let
fb_get_options() return an error  when the "off" option is present.  But I'm
not going to implement it unless we get a lot of complaints.

Tony