Re: fbdraw 0.1 available

["Antonino A. Daplas" <adaplas@hotpop.com>]

On Saturday 11 September 2004 10:43, Zack wrote:
> My changes to permit (optional) in-kernel drawing for applications
> are available. It's only version 0.1 at this point, meaning alpha,
> but I'm happy with the performance and structure. I've included
> a test application that allows benchmarking.
>
> home.comcast.net/~plinius/fbdraw-0.1.tar.gz
>
> To install, move the tarfile to the 2.6.8.1 root dir, and use
> tar zxfv fbdraw-0.1.tar.gz.
>
> Constructive criticism is welcome.

(Better if you provided an inlined file so it's easier to make comments) 

Here's a few, just from a quick scan:

1. First, you need to follow Documentation/CodingStyle.

2. Do not directly access framebuffer memory, use: 

fb_{read|write}{b|w|l}

3. Do not use copy_{to|from}_user when the destination/source is the
framebuffer.

4. Do not memset the framebuffer.  You can probably create an equivalent
function using fb_read/write.  (Once, we have fb_memset and fb_memcpy, but
they're gone in 2.6).

Tony




-------------------------------------------------------
This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170
Project Admins to receive an Apple iPod Mini FREE for your judgement on
who ports your project to Linux PPC the best. Sponsored by IBM. 
Deadline: Sept. 13. Go here: http://sf.net/ppc_contest.php