From: "Antonino A. Daplas" <adaplas@hotpop.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Linux Fbdev development list
<linux-fbdev-devel@lists.sourceforge.net>,
Nicolas Boichat <nicolas@boichat.ch>
Subject: [PATCH] fbdev: rivafb I2C timings too fast
Date: Wed, 15 Sep 2004 05:53:20 +0800 [thread overview]
Message-ID: <200409150553.20272.adaplas@hotpop.com> (raw)
The timings in rivafb's i2c, although enough for EDID reading, are too fast
for some user applications. Reported by Nicolas Boichat
<nicolas@boichat.ch>.
This patch increases the timeouts.
Signed-off-by: Antonino Daplas <adaplas@pol.net>
---
rivafb-i2c.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff -uprN linux-2.6.9-rc1-mm5-orig/drivers/video/riva/rivafb-i2c.c linux-2.6.9-rc1-mm5/drivers/video/riva/rivafb-i2c.c
--- linux-2.6.9-rc1-mm5-orig/drivers/video/riva/rivafb-i2c.c 2004-09-13 19:50:17.000000000 +0800
+++ linux-2.6.9-rc1-mm5/drivers/video/riva/rivafb-i2c.c 2004-09-15 05:38:19.307344544 +0800
@@ -105,9 +105,8 @@ static int riva_setup_i2c_bus(struct riv
chan->algo.setscl = riva_gpio_setscl;
chan->algo.getsda = riva_gpio_getsda;
chan->algo.getscl = riva_gpio_getscl;
- chan->algo.udelay = 5;
- chan->algo.mdelay = 5;
- chan->algo.timeout = 10;
+ chan->algo.udelay = 40;
+ chan->algo.timeout = 20;
chan->algo.data = chan;
i2c_set_adapdata(&chan->adapter, chan);
-------------------------------------------------------
This SF.Net email is sponsored by: thawte's Crypto Challenge Vl
Crack the code and win a Sony DCRHC40 MiniDV Digital Handycam
Camcorder. More prizes in the weekly Lunch Hour Challenge.
Sign up NOW http://ad.doubleclick.net/clk;10740251;10262165;m
next reply other threads:[~2004-09-14 21:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-14 21:53 Antonino A. Daplas [this message]
2004-09-14 22:06 ` [PATCH] fbdev: rivafb I2C timings too fast Nicolas Boichat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200409150553.20272.adaplas@hotpop.com \
--to=adaplas@hotpop.com \
--cc=akpm@osdl.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=nicolas@boichat.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).