From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: [PATCH 495] Amifb: use new amifb:off logic to enhance audio experience Date: Sat, 2 Oct 2004 19:00:24 +0200 Sender: linux-fbdev-devel-admin@lists.sourceforge.net Message-ID: <200410021700.i92H0OgM021193@anakin.of.borg> Reply-To: linux-fbdev-devel@lists.sourceforge.net Return-path: Received: from sc8-sf-mx1-b.sourceforge.net ([10.3.1.11] helo=sc8-sf-mx1.sourceforge.net) by sc8-sf-list1.sourceforge.net with esmtp (Exim 4.30) id 1CDnGO-0004OR-8V for linux-fbdev-devel@lists.sourceforge.net; Sat, 02 Oct 2004 10:01:40 -0700 Received: from nl-ams-slo-l4-01-pip-8.chellonetwork.com ([213.46.243.27] helo=amsfep15-int.chello.nl) by sc8-sf-mx1.sourceforge.net with esmtp (Exim 4.41) id 1CDnFI-0006Wg-Jk for linux-fbdev-devel@lists.sourceforge.net; Sat, 02 Oct 2004 10:01:40 -0700 Errors-To: linux-fbdev-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Id: List-Post: List-Help: List-Subscribe: , List-Archive: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Linus Torvalds , Andrew Morton Cc: Linux Kernel Development , Linux Fbdev , Geert Uytterhoeven Amiga frame buffer: We used to have a local hack in fbmem.c to always call the fbdev setup() routines, even when an fbdev was explicitly disabled on the kernel command line (video=xxx:off). This allowed amifb to suspend the monitor, but program the sync generator of the video controller in Denise/Lisa to a 31 kHz/70 Hz mode, increasing the maximum audio playback frequency. Thanks to the recently introduced fb_get_options() routine, we can kill the local hack and just use the return value of fb_get_options(). Signed-off-by: Geert Uytterhoeven --- linux-2.6.9-rc3/drivers/video/amifb.c 2004-09-30 18:08:25.000000000 +0200 +++ linux-m68k-2.6.9-rc3/drivers/video/amifb.c 2004-09-30 20:11:02.000000000 +0200 @@ -1239,8 +1239,6 @@ int __init amifb_setup(char *options) if (!strcmp(this_opt, "inverse")) { amifb_inverse = 1; fb_invert_cmaps(); - } else if (!strcmp(this_opt, "off")) { - amifb_video_off(); } else if (!strcmp(this_opt, "ilbm")) amifb_ilbm = 1; else if (!strncmp(this_opt, "monitorcap:", 11)) @@ -2260,8 +2258,10 @@ int __init amifb_init(void) #ifndef MODULE char *option = NULL; - if (fb_get_options("amifb", &option)) + if (fb_get_options("amifb", &option)) { + amifb_video_off(); return -ENODEV; + } amifb_setup(option); #endif if (!MACH_IS_AMIGA || !AMIGAHW_PRESENT(AMI_VIDEO)) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ------------------------------------------------------- This SF.net email is sponsored by: IT Product Guide on ITManagersJournal Use IT products in your business? Tell us what you think of them. Give us Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more http://productguide.itmanagersjournal.com/guidepromo.tmpl