latest patch for atyfb

latest patch for atyfb

[Alexander Kern]

[-- Attachment #1: Type: text/plain, Size: 143 bytes --]

Hi, 
now against 2.6.9-rc3-mm2. Changed since latest; resync + mtrr patch from 
Ville(doesn't work by me, but doesn't broke too).

Cheers Alex

[-- Attachment #2: mach64-2.6.9-rc3-mm2.diff.gz --]
[-- Type: application/x-gzip, Size: 53951 bytes --]

Re: latest patch for atyfb

[Alexander Kern]

Am Dienstag, 12. Oktober 2004 14:42 schrieb Antonino A. Daplas:

> BTW, can you send me a changelog?
>
> Tony

Alphabetical sort, please if I forgot something, add you comment.
 
Alex Kern
[PATCH] port Daniel Mantione 2.4 driver to 2.6
[PATCH] add more pci_id number
[PATCH] add accelerated imgblit
[PATCH] revert SDRAM_MAGIC_PLL to old behaviour
[PATCH] do a "from BIOS" initialisation only by __i386__

Arnaud FONTAINE
[PATCH atyfb] correction for 3D Rage Mobility L

Geert Uytterhoeven
[PATCH atyfb] Atari Atyfb fixes
[PATCH atyfb] Atyfb on Mach64 GX or Atari
[PATCH 468] m68k sparse floating point

James Simmons
[PATCH add] port to framebuffer_alloc api

Nicolas Souchu
[PATCH] I do not found a copy, but it was incorporated too

Ville Syrjälä
[PATCH] fix pan with doublescan
[PATCH] another double scan fix
[PATCH] disable linear aperture register access
[PATCH] Memory type correction
[PATCH] atyfb (2.6): Fix mmio_start
[PATCH] atyfb (2.6): Fix mem_refresh_rate for Mobility
[PATCH] atyfb (2.6): Add RGB565 support
[PATCH] atyfb: Blank LCD by turning off backlight voltage
[PATCH] atyfb: Rage LT LCD register access
[PATCH] atyfb: vblank irq support
[PATCH] atyfb: MTRR support



-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl

Re: latest patch for atyfb

[Ville Syrjälä]

On Tue, Oct 12, 2004 at 12:24:49AM +0200, Alexander Kern wrote:
> Hi, 
> now against 2.6.9-rc3-mm2. Changed since latest; resync + mtrr patch from 
> Ville(doesn't work by me, but doesn't broke too).

Do you mean that it should work (in theory) but doesn't?

-- 
Ville Syrjälä
syrjala@sci.fi
http://www.sci.fi/~syrjala/


-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl

Re: latest patch for atyfb

[Alexander Kern]

Am Samstag, 16. Oktober 2004 02:15 schrieb Ville Syrjälä:
> On Tue, Oct 12, 2004 at 12:24:49AM +0200, Alexander Kern wrote:
> > Hi,
> > now against 2.6.9-rc3-mm2. Changed since latest; resync + mtrr patch from
> > Ville(doesn't work by me, but doesn't broke too).
>
> Do you mean that it should work (in theory) but doesn't?
No, I feel that on my machine I cannot see the difference, because
somebody (BIOS?) register 4 MB WriteCombining area before atyfb even starts.
Naturally add_mtrr(with whole memory, 8 MB) always failed.
Cheers
Alex


-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl

Re: latest patch for atyfb, even more patches

[Alexander Kern]

[-- Attachment #1: Type: text/plain, Size: 2091 bytes --]

Am Freitag, 15. Oktober 2004 21:25 schrieb Alexander Kern:
> Am Dienstag, 12. Oktober 2004 14:42 schrieb Antonino A. Daplas:
> > BTW, can you send me a changelog?
> >
> > Tony
>
> Alphabetical sort, please if I forgot something, add you comment.
>
> Alex Kern
> [PATCH] port Daniel Mantione 2.4 driver to 2.6
> [PATCH] add more pci_id number
> [PATCH] add accelerated imgblit
> [PATCH] revert SDRAM_MAGIC_PLL to old behaviour
> [PATCH] do a "from BIOS" initialisation only by __i386__
>
> Arnaud FONTAINE
> [PATCH atyfb] correction for 3D Rage Mobility L
>
> Geert Uytterhoeven
> [PATCH atyfb] Atari Atyfb fixes
> [PATCH atyfb] Atyfb on Mach64 GX or Atari
> [PATCH 468] m68k sparse floating point
>
> James Simmons
> [PATCH add] port to framebuffer_alloc api
>
> Nicolas Souchu
> [PATCH] I do not found a copy, but it was incorporated too
>
> Ville Syrjälä
> [PATCH] fix pan with doublescan
> [PATCH] another double scan fix
> [PATCH] disable linear aperture register access
> [PATCH] Memory type correction
> [PATCH] atyfb (2.6): Fix mmio_start
> [PATCH] atyfb (2.6): Fix mem_refresh_rate for Mobility
> [PATCH] atyfb (2.6): Add RGB565 support
> [PATCH] atyfb: Blank LCD by turning off backlight voltage
> [PATCH] atyfb: Rage LT LCD register access
> [PATCH] atyfb: vblank irq support
> [PATCH] atyfb: MTRR support
>
Hi,  here is more patches to go

Our cursor API is a bit understandable, 80 % of drivers given up, and using 
soft_cursor (see a comment in ffb.c#61).

Three drivers made an error and use cursor->enable insted of
info->cursor.enable.

[PATCH atyfb] fix hw cursor breakage

[PATCH g364fb] fix hw cursor breakage

[PATCH imsttfb] fix hw cursor breakage

And tdfxfb is in my mind, broken as a hell.
cut from tdfxfb_cursor function

#ifdef TDFX_HARDWARE_CURSOR
static int tdfxfb_cursor(struct fb_info *info, struct fb_cursor *cursor)
{
......
	if (info->cursor.enable) {    < Hey it's right
......
	/* Turn the cursor on */
	cursor->enable = 1;
	info->cursor = *cursor;    < Outch!
}
#endif

Regards Alex

[-- Attachment #2: cursor-atyfb.patch --]
[-- Type: text/x-diff, Size: 426 bytes --]

--- linux-2.6.8/drivers/video/aty/mach64_cursor.c	2004-10-15 22:25:16.000000000 +0200
+++ linux-2.6.head/drivers/video/aty/mach64_cursor.c	2004-10-16 22:57:34.434688080 +0200
@@ -198,7 +198,7 @@ int atyfb_cursor(struct fb_info *info, s
 	    }
 	}	
 	
-	if (cursor->enable) {
+	if (info->cursor.enable) {
 		wait_for_fifo(1, par);
 		aty_st_le32(GEN_TEST_CNTL, aty_ld_le32(GEN_TEST_CNTL, par)
 			    | HWCURSOR_ENABLE, par);

[-- Attachment #3: cursor-g364fb.patch --]
[-- Type: text/x-diff, Size: 416 bytes --]

--- linux-2.6.8/drivers/video/g364fb.c	2004-10-15 22:19:15.000000000 +0200
+++ linux-2.6.head/drivers/video/g364fb.c	2004-10-16 23:11:33.687102320 +0200
@@ -128,7 +128,7 @@ static struct fb_ops g364fb_ops = {
 int g364fb_cursor(struct fb_info *info, struct fb_cursor *cursor)
 {
 	
-	switch (cursor->enable) {
+	switch (info->cursor.enable) {
 	case CM_ERASE:
 		*(unsigned int *) CTLA_REG |= CURS_TOGGLE;
 		break;

[-- Attachment #4: cursor-imsttfb.patch --]
[-- Type: text/x-diff, Size: 374 bytes --]

--- linux-2.6.8/drivers/video/imsttfb.c	2004-10-15 22:21:24.000000000 +0200
+++ linux-2.6.head/drivers/video/imsttfb.c	2004-10-16 23:12:28.787725752 +0200
@@ -1249,7 +1249,7 @@ imsttfb_cursor(struct fb_info *info, str
 
 		imsttfb_load_cursor_image(par, xx, yy, fgc);
 	}
-	if (cursor->enable)
+	if (info->cursor.enable)
 		imstt_set_cursor(info, cursor, 1);
 	return 0;
 }

Re: latest patch for atyfb, even more patches

[Antonino A. Daplas]

On Sunday 17 October 2004 05:47, Alexander Kern wrote:
> Am Freitag, 15. Oktober 2004 21:25 schrieb Alexander Kern:
> > Am Dienstag, 12. Oktober 2004 14:42 schrieb Antonino A. Daplas:
>
> Hi,  here is more patches to go
>
> Our cursor API is a bit understandable, 80 % of drivers given up, and using
> soft_cursor (see a comment in ffb.c#61).
>
> Three drivers made an error and use cursor->enable insted of
> info->cursor.enable.
>
> [PATCH atyfb] fix hw cursor breakage
>
> [PATCH g364fb] fix hw cursor breakage
>
> [PATCH imsttfb] fix hw cursor breakage
>
> And tdfxfb is in my mind, broken as a hell.
> cut from tdfxfb_cursor function
>
> #ifdef TDFX_HARDWARE_CURSOR <-- not defined at all

Yep, tdfxfb_cursor() doesn't get compiled as it's seriously broken.

> static int tdfxfb_cursor(struct fb_info *info, struct fb_cursor *cursor)
> {
> ......
> 	if (info->cursor.enable) {    < Hey it's right
> ......
> 	/* Turn the cursor on */
> 	cursor->enable = 1;
> 	info->cursor = *cursor;    < Outch!
> }
> #endif
>

Yep, the cursor API, IMHO is very confusing, some fields are taken from
info->cursor (ie, mask, enable, rop), the rest from the passed fb_cursor
structure. There are also a lot of short-circuits in the cursor code path.

I've cleaned all this up in my tree so all drivers will use fields in the
passed fb_cursor structure _only_. Also, drivers need not store the changed
fields in info->cursor, fbcon will do that for you.  The end result is that
drivers don't have to look at info->cursor at all.  

Driver changes should be minimal, all references to info->cursor will just
be changed to cursor.  And things like this can be removed:

if (cursor->set & FB_CUR_BLAH)
	info->cursor.blah = cursor->blah; <-- this line can be removed

I'll document all of this in skeletenfb.c.

Other changes: cleaned up the cursor code path.

I'll submit the cursor API patches (including my attempt to modify
drivers) when 2.6.9 comes out.

Tony




-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl