linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH fbtest] fix blue feet by 24bpp
@ 2004-10-17 22:25 Alexander Kern
  0 siblings, 0 replies; only message in thread
From: Alexander Kern @ 2004-10-17 22:25 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: fbdev mail-list

[-- Attachment #1: Type: text/plain, Size: 335 bytes --]

Hello, I have investigate, that blue feet by penguin in fbtest and 24bpp deep 
was caused by error in cfb24.c.
This patch fix it for me



But I have steel problems in test 007 and 008

I have posted photo pixs on 
http://home.arcor.de/alexander.khe/atyfb/fbtest-results/

Is it the similar problems with byte separation?

Cheers
Alex

[-- Attachment #2: fbtest24bppfix.patch --]
[-- Type: text/x-diff, Size: 717 bytes --]

--- drawops/cfb24.c.orig	2002-10-08 16:20:27.000000000 +0200
+++ drawops/cfb24.c	2004-10-17 15:08:02.000000000 +0200
@@ -33,9 +33,9 @@ static void cfb24_setpixel(u32 x, u32 y,
     u8 *dst;
 
     dst = &screen[y*screen_width+x*3];
-    dst[0] = (pixel >> 16) & 0xff;
+    dst[2] = (pixel >> 16) & 0xff;
     dst[1] = (pixel >> 8) & 0xff;
-    dst[2] = pixel & 0xff;
+    dst[0] = pixel & 0xff;
 }
 
 static pixel_t cfb24_getpixel(u32 x, u32 y)
@@ -43,7 +43,7 @@ static pixel_t cfb24_getpixel(u32 x, u32
     const u8 *src;
 
     src = &screen[y*screen_width+x*3];
-    return (src[0] << 16) | (src[1] << 8) | src[2];
+    return (src[2] << 16) | (src[1] << 8) | src[0];
 }
 
 const struct drawops cfb24_drawops = {

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2004-10-17 22:25 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-10-17 22:25 [PATCH fbtest] fix blue feet by 24bpp Alexander Kern

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).