From: Jim Hague <jim.hague@acm.org>
To: linux-fbdev-devel@lists.sourceforge.net, Andrew Morton <akpm@osdl.org>
Subject: [PATCH 2/2] pm2fb: Colour palette fixes
Date: Fri, 22 Oct 2004 10:54:37 +0100 [thread overview]
Message-ID: <20041022105437.4e5cebf0@hagrid.bear-cave.org.uk> (raw)
- Hardware CLUT only needs setting on pseudocolor.
- Pseudo palette values need to be 32bit wide for cfb_*().
Signed-off-by: Jim Hague <jim.hague@acm.org>
diff -u -p -r1.24 pm2fb.c
--- drivers/video/pm2fb.c 23 Sep 2004 01:19:45 -0000 1.24
+++ drivers/video/pm2fb.c 22 Oct 2004 09:36:32 -0000
@@ -877,7 +877,6 @@ static int pm2fb_setcolreg(unsigned regn
green = CNVT_TOHW(green, info->var.green.length);
blue = CNVT_TOHW(blue, info->var.blue.length);
transp = CNVT_TOHW(transp, info->var.transp.length);
- set_color(par, regno, red, green, blue);
break;
case FB_VISUAL_DIRECTCOLOR:
/* example here assumes 8 bit DAC. Might be different
@@ -904,12 +903,8 @@ static int pm2fb_setcolreg(unsigned regn
switch (info->var.bits_per_pixel) {
case 8:
- /* Yes some hand held devices have this. */
- ((u8*)(info->pseudo_palette))[regno] = v;
break;
case 16:
- ((u16*)(info->pseudo_palette))[regno] = v;
- break;
case 24:
case 32:
((u32*)(info->pseudo_palette))[regno] = v;
@@ -917,7 +912,9 @@ static int pm2fb_setcolreg(unsigned regn
}
return 0;
}
- /* ... */
+ else if (info->fix.visual == FB_VISUAL_PSEUDOCOLOR)
+ set_color(par, regno, red, green, blue);
+
return 0;
}
-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl
reply other threads:[~2004-10-22 9:54 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041022105437.4e5cebf0@hagrid.bear-cave.org.uk \
--to=jim.hague@acm.org \
--cc=akpm@osdl.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).