From: Andrew Morton <akpm@osdl.org>
To: adaplas@pol.net
Cc: adaplas@hotpop.com, linux-fbdev-devel@lists.sourceforge.net,
dok@directfb.org, mpruikko@cc.hut.fi, neo@convergence.de
Subject: Re: [PATCH 1/2] fbdev: S3 Savage Framebuffer Driver
Date: Mon, 25 Oct 2004 02:02:55 -0700 [thread overview]
Message-ID: <20041025020255.01d0a126.akpm@osdl.org> (raw)
In-Reply-To: <200410230436.42009.adaplas@hotpop.com>
"Antonino A. Daplas" <adaplas@hotpop.com> wrote:
>
> S3 Savage Frambuffer Driver for the following chipsets:
build fixes:
drivers/video/savage/savagefb.c:1368: macro `SavagePrintRegs' used without args
drivers/video/savage/savagefb.c:1926: macro `SavagePrintRegs' used without args
drivers/video/savage/savagefb.c:2141: macro `SavagePrintRegs' used without args
drivers/video/savage/savagefb.c: In function `savagefb_init':
drivers/video/savage/savagefb.c:2276: warning: implicit declaration of function `savagefb_setup'
Signed-off-by: Andrew Morton <akpm@osdl.org>
---
25-akpm/drivers/video/savage/savagefb.c | 5 ++---
25-akpm/drivers/video/savage/savagefb.h | 2 +-
2 files changed, 3 insertions(+), 4 deletions(-)
diff -puN drivers/video/savage/savagefb.h~savagefb-build-fix drivers/video/savage/savagefb.h
--- 25/drivers/video/savage/savagefb.h~savagefb-build-fix 2004-10-25 01:59:47.303620792 -0700
+++ 25-akpm/drivers/video/savage/savagefb.h 2004-10-25 01:59:51.100043648 -0700
@@ -21,7 +21,7 @@
# define DBG(x) printk (KERN_DEBUG "savagefb: %s\n", (x));
#else
# define DBG(x)
-# define SavagePrintRegs(x)
+# define SavagePrintRegs(...)
#endif
diff -puN drivers/video/savage/savagefb.c~savagefb-build-fix drivers/video/savage/savagefb.c
--- 25/drivers/video/savage/savagefb.c~savagefb-build-fix 2004-10-25 02:00:18.228919432 -0700
+++ 25-akpm/drivers/video/savage/savagefb.c 2004-10-25 02:01:45.080715952 -0700
@@ -2248,9 +2248,9 @@ static void __exit savage_done (void)
/* ************************* init in-kernel code ************************** */
-#ifndef MODULE
int __init savagefb_setup(char *options)
{
+#ifndef MODULE
char *this_opt;
if (!options || !*options)
@@ -2259,10 +2259,9 @@ int __init savagefb_setup(char *options)
while ((this_opt = strsep(&options, ",")) != NULL) {
mode_option = this_opt;
}
-
+#endif /* !MODULE */
return 0;
}
-#endif /* !MODULE */
int __init savagefb_init(void)
{
_
-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl
next prev parent reply other threads:[~2004-10-25 9:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-22 20:36 [PATCH 1/2] fbdev: S3 Savage Framebuffer Driver Antonino A. Daplas
2004-10-22 23:38 ` Denis Oliver Kropp
2004-10-25 9:02 ` Andrew Morton [this message]
2004-10-25 12:34 ` Antonino A. Daplas
2004-11-10 19:17 ` Jurriaan
2004-11-11 2:23 ` Antonino A. Daplas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041025020255.01d0a126.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=adaplas@hotpop.com \
--cc=adaplas@pol.net \
--cc=dok@directfb.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=mpruikko@cc.hut.fi \
--cc=neo@convergence.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).