From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: Andrew Morton <akpm@osdl.org>,
ajoshi@shell.unixbox.com,
linux-fbdev-devel@lists.sourceforge.net
Cc: linux-kernel@vger.kernel.org, benh@kernel.crashing.org
Subject: [PATCH] radeonfb: If no video memory, exit with error [repost]
Date: Tue, 26 Oct 2004 16:03:24 -0600 [thread overview]
Message-ID: <200410261603.24434.bjorn.helgaas@hp.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 977 bytes --]
Posted this last week (10/21) but haven't seen any response.
Would you consider this for the next -mm? Also attached in
case kmail mangles the whitespace.
[PATCH] radeonfb: If no video memory, exit with error
Nothing good will happen if we try to ioremap and use a zero-sized
frame buffer. I observed this problem on an ia64 sx1000 box, where
the BIOS doesn't run the option ROM. If we try to continue, radeonfb
just gets hopelessly confused because the card isn't initialized
correctly.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
===== drivers/video/aty/radeon_base.c 1.32 vs edited =====
--- 1.32/drivers/video/aty/radeon_base.c 2004-10-19 03:40:34 -06:00
+++ edited/drivers/video/aty/radeon_base.c 2004-10-21 11:50:51 -06:00
@@ -2186,7 +2186,9 @@
rinfo->video_ram = 8192 * 1024;
break;
default:
- break;
+ printk (KERN_ERR "radeonfb: no video RAM reported\n");
+ ret = -ENXIO;
+ goto err_unmap_rom;
}
}
[-- Attachment #2: radeonfb-no-vram.patch --]
[-- Type: text/x-diff, Size: 819 bytes --]
[PATCH] radeonfb: If no video memory, exit with error
Nothing good will happen if we try to ioremap and use a zero-sized
frame buffer. I observed this problem on an ia64 sx1000 box, where
the BIOS doesn't run the option ROM. If we try to continue, radeonfb
just gets hopelessly confused because the card isn't initialized
correctly.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
===== drivers/video/aty/radeon_base.c 1.32 vs edited =====
--- 1.32/drivers/video/aty/radeon_base.c 2004-10-19 03:40:34 -06:00
+++ edited/drivers/video/aty/radeon_base.c 2004-10-21 11:50:51 -06:00
@@ -2186,7 +2186,9 @@
rinfo->video_ram = 8192 * 1024;
break;
default:
- break;
+ printk (KERN_ERR "radeonfb: no video RAM reported\n");
+ ret = -ENXIO;
+ goto err_unmap_rom;
}
}
next reply other threads:[~2004-10-26 22:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-26 22:03 Bjorn Helgaas [this message]
2004-10-26 23:50 ` [PATCH] radeonfb: If no video memory, exit with error [repost] Benjamin Herrenschmidt
2004-10-27 9:42 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200410261603.24434.bjorn.helgaas@hp.com \
--to=bjorn.helgaas@hp.com \
--cc=ajoshi@shell.unixbox.com \
--cc=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).