* [PATCH 7/8] fbdev: atyfb_base.c requires atyfb_cursor()
@ 2004-11-02 11:46 Antonino A. Daplas
2004-11-02 13:14 ` S1D13506 CRT ramprasad
2004-11-02 13:58 ` [PATCH 7/8] fbdev: atyfb_base.c requires atyfb_cursor() Ville Syrjälä
0 siblings, 2 replies; 6+ messages in thread
From: Antonino A. Daplas @ 2004-11-02 11:46 UTC (permalink / raw)
To: Andrew Morton; +Cc: Linux Fbdev development list, Olaf Hering
atyfb_base.c requires atyfb_cursor, but it is only available for linking
if CONFIG_FB_ATY_CT=y.
This patch moves the .o file to the CONFIG_FB_ATY rule.
Signed-off-by: Olaf Hering <olh@suse.de>
Signed-off-by: Antonino Daplas <adaplas@pol.net>
---
Makefile | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff -Nru a/drivers/video/aty/Makefile b/drivers/video/aty/Makefile
--- a/drivers/video/aty/Makefile 2004-10-19 20:22:37 +08:00
+++ b/drivers/video/aty/Makefile 2004-11-01 22:42:04 +08:00
@@ -2,9 +2,9 @@
obj-$(CONFIG_FB_ATY128) += aty128fb.o
obj-$(CONFIG_FB_RADEON) += radeonfb.o
-atyfb-y := atyfb_base.o mach64_accel.o
+atyfb-y := atyfb_base.o mach64_accel.o mach64_cursor.o
atyfb-$(CONFIG_FB_ATY_GX) += mach64_gx.o
-atyfb-$(CONFIG_FB_ATY_CT) += mach64_ct.o mach64_cursor.o
+atyfb-$(CONFIG_FB_ATY_CT) += mach64_ct.o
atyfb-objs := $(atyfb-y)
radeonfb-y := radeon_base.o radeon_pm.o radeon_monitor.o radeon_accel.o
-------------------------------------------------------
This SF.Net email is sponsored by:
Sybase ASE Linux Express Edition - download now for FREE
LinuxWorld Reader's Choice Award Winner for best database on Linux.
http://ads.osdn.com/?ad_id=5588&alloc_id=12065&op=click
^ permalink raw reply [flat|nested] 6+ messages in thread
* S1D13506 CRT
2004-11-02 11:46 [PATCH 7/8] fbdev: atyfb_base.c requires atyfb_cursor() Antonino A. Daplas
@ 2004-11-02 13:14 ` ramprasad
2004-11-02 13:58 ` [PATCH 7/8] fbdev: atyfb_base.c requires atyfb_cursor() Ville Syrjälä
1 sibling, 0 replies; 6+ messages in thread
From: ramprasad @ 2004-11-02 13:14 UTC (permalink / raw)
To: linux-fbdev-devel
Hi All,
I am using 2.4.19-rmk7-pxa1 kernel.I have an S1D13506 LCD/CRT
controller. has anybody got this working on PXA processor.any hint on
how to go about. I have to configure for CRT display.
Thanks in advance,
Ramprasad
-------------------------------------------------------
This SF.Net email is sponsored by:
Sybase ASE Linux Express Edition - download now for FREE
LinuxWorld Reader's Choice Award Winner for best database on Linux.
http://ads.osdn.com/?ad_id=5588&alloc_id=12065&op=click
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 7/8] fbdev: atyfb_base.c requires atyfb_cursor()
2004-11-02 11:46 [PATCH 7/8] fbdev: atyfb_base.c requires atyfb_cursor() Antonino A. Daplas
2004-11-02 13:14 ` S1D13506 CRT ramprasad
@ 2004-11-02 13:58 ` Ville Syrjälä
2004-11-02 21:31 ` Antonino A. Daplas
1 sibling, 1 reply; 6+ messages in thread
From: Ville Syrjälä @ 2004-11-02 13:58 UTC (permalink / raw)
To: linux-fbdev-devel; +Cc: Andrew Morton, Olaf Hering
On Tue, Nov 02, 2004 at 07:46:26PM +0800, Antonino A. Daplas wrote:
> atyfb_base.c requires atyfb_cursor, but it is only available for linking
> if CONFIG_FB_ATY_CT=y.
> This patch moves the .o file to the CONFIG_FB_ATY rule.
Here's a better fix. It was a part of my swcursor patch which was
partially included. Looks like Alex accidentally dropped this part.
Fix atyfb cursor problems:
- oops with noaccel option
- CONFIG_FB_ATY_CT dependency problem
Signed-off-by: Ville Syrjala <syrjala@sci.fi>
---
atyfb_base.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
diff -Nur a/drivers/video/aty/atyfb_base.c b/drivers/video/aty/atyfb_base.c
--- a/drivers/video/aty/atyfb_base.c 2004-11-02 15:20:23.199495000 +0200
+++ b/drivers/video/aty/atyfb_base.c 2004-11-02 15:22:20.979495000 +0200
@@ -292,7 +292,7 @@
.fb_fillrect = atyfb_fillrect,
.fb_copyarea = atyfb_copyarea,
.fb_imageblit = atyfb_imageblit,
- .fb_cursor = atyfb_cursor,
+ .fb_cursor = soft_cursor,
#ifdef __sparc__
.fb_mmap = atyfb_mmap,
#endif
--
Ville Syrjälä
syrjala@sci.fi
http://www.sci.fi/~syrjala/
-------------------------------------------------------
This SF.Net email is sponsored by:
Sybase ASE Linux Express Edition - download now for FREE
LinuxWorld Reader's Choice Award Winner for best database on Linux.
http://ads.osdn.com/?ad_idU88&alloc_id\x12065&op=click
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 7/8] fbdev: atyfb_base.c requires atyfb_cursor()
2004-11-02 13:58 ` [PATCH 7/8] fbdev: atyfb_base.c requires atyfb_cursor() Ville Syrjälä
@ 2004-11-02 21:31 ` Antonino A. Daplas
2004-11-02 22:26 ` Ville Syrjälä
0 siblings, 1 reply; 6+ messages in thread
From: Antonino A. Daplas @ 2004-11-02 21:31 UTC (permalink / raw)
To: linux-fbdev-devel, Ville Syrjälä; +Cc: Andrew Morton, Olaf Hering
On Tuesday 02 November 2004 21:58, Ville Syrjälä wrote:
> On Tue, Nov 02, 2004 at 07:46:26PM +0800, Antonino A. Daplas wrote:
> > atyfb_base.c requires atyfb_cursor, but it is only available for linking
> > if CONFIG_FB_ATY_CT=y.
> > This patch moves the .o file to the CONFIG_FB_ATY rule.
>
> Here's a better fix. It was a part of my swcursor patch which was
> partially included. Looks like Alex accidentally dropped this part.
>
>
> Fix atyfb cursor problems:
> - oops with noaccel option
> - CONFIG_FB_ATY_CT dependency problem
>
If I read Alex's patch correctly, it looks like the aty has a working
hardware cursor implementation, is this correct? Then a better patch may be
to use soft_cursor if noaccel is true, and atyfb_cursor otherwise.
Tony
-------------------------------------------------------
This SF.Net email is sponsored by:
Sybase ASE Linux Express Edition - download now for FREE
LinuxWorld Reader's Choice Award Winner for best database on Linux.
http://ads.osdn.com/?ad_idU88&alloc_id\x12065&op=click
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 7/8] fbdev: atyfb_base.c requires atyfb_cursor()
2004-11-02 21:31 ` Antonino A. Daplas
@ 2004-11-02 22:26 ` Ville Syrjälä
2004-11-03 2:39 ` Antonino A. Daplas
0 siblings, 1 reply; 6+ messages in thread
From: Ville Syrjälä @ 2004-11-02 22:26 UTC (permalink / raw)
To: linux-fbdev-devel
On Wed, Nov 03, 2004 at 05:31:36AM +0800, Antonino A. Daplas wrote:
> On Tuesday 02 November 2004 21:58, Ville Syrjälä wrote:
> > On Tue, Nov 02, 2004 at 07:46:26PM +0800, Antonino A. Daplas wrote:
> > > atyfb_base.c requires atyfb_cursor, but it is only available for linking
> > > if CONFIG_FB_ATY_CT=y.
> > > This patch moves the .o file to the CONFIG_FB_ATY rule.
> >
> > Here's a better fix. It was a part of my swcursor patch which was
> > partially included. Looks like Alex accidentally dropped this part.
> >
> >
> > Fix atyfb cursor problems:
> > - oops with noaccel option
> > - CONFIG_FB_ATY_CT dependency problem
> >
>
> If I read Alex's patch correctly, it looks like the aty has a working
> hardware cursor implementation, is this correct? Then a better patch may be
> to use soft_cursor if noaccel is true, and atyfb_cursor otherwise.
That is how things work with this patch. aty_init_cursor() sets fb_cursor
to atyfb_cursor.
--
Ville Syrjälä
syrjala@sci.fi
http://www.sci.fi/~syrjala/
-------------------------------------------------------
This SF.Net email is sponsored by:
Sybase ASE Linux Express Edition - download now for FREE
LinuxWorld Reader's Choice Award Winner for best database on Linux.
http://ads.osdn.com/?ad_idU88&alloc_id\x12065&op=click
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 7/8] fbdev: atyfb_base.c requires atyfb_cursor()
2004-11-02 22:26 ` Ville Syrjälä
@ 2004-11-03 2:39 ` Antonino A. Daplas
0 siblings, 0 replies; 6+ messages in thread
From: Antonino A. Daplas @ 2004-11-03 2:39 UTC (permalink / raw)
To: linux-fbdev-devel, Ville Syrjälä
On Wednesday 03 November 2004 06:26, Ville Syrjälä wrote:
> On Wed, Nov 03, 2004 at 05:31:36AM +0800, Antonino A. Daplas wrote:
> > On Tuesday 02 November 2004 21:58, Ville Syrjälä wrote:
> > > On Tue, Nov 02, 2004 at 07:46:26PM +0800, Antonino A. Daplas wrote:
> > > > atyfb_base.c requires atyfb_cursor, but it is only available for
> > > > linking if CONFIG_FB_ATY_CT=y.
> > > > This patch moves the .o file to the CONFIG_FB_ATY rule.
> > >
> > > Here's a better fix. It was a part of my swcursor patch which was
> > > partially included. Looks like Alex accidentally dropped this part.
> > >
> > >
> > > Fix atyfb cursor problems:
> > > - oops with noaccel option
> > > - CONFIG_FB_ATY_CT dependency problem
> >
> > If I read Alex's patch correctly, it looks like the aty has a working
> > hardware cursor implementation, is this correct? Then a better patch may
> > be to use soft_cursor if noaccel is true, and atyfb_cursor otherwise.
>
> That is how things work with this patch. aty_init_cursor() sets fb_cursor
> to atyfb_cursor.
Ah, ok, did not see that.
Tony
-------------------------------------------------------
This SF.Net email is sponsored by:
Sybase ASE Linux Express Edition - download now for FREE
LinuxWorld Reader's Choice Award Winner for best database on Linux.
http://ads.osdn.com/?ad_idU88&alloc_id\x12065&op=click
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2004-11-03 2:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-11-02 11:46 [PATCH 7/8] fbdev: atyfb_base.c requires atyfb_cursor() Antonino A. Daplas
2004-11-02 13:14 ` S1D13506 CRT ramprasad
2004-11-02 13:58 ` [PATCH 7/8] fbdev: atyfb_base.c requires atyfb_cursor() Ville Syrjälä
2004-11-02 21:31 ` Antonino A. Daplas
2004-11-02 22:26 ` Ville Syrjälä
2004-11-03 2:39 ` Antonino A. Daplas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).