Re: Re: [PATCH 1/8] fbcon: Do not touch hardware if vc_mode != KD_TEXT

["Antonino A. Daplas" <adaplas@hotpop.com>]

On Wednesday 03 November 2004 06:27, Benjamin Herrenschmidt wrote:
> On Tue, 2004-11-02 at 19:46 +0800, Antonino A. Daplas wrote:
> > The frambuffer console is still writing to the graphics hardware even if
> > the hardware is not owned anymore by the console.  This can lead to
> > crashes with some hardware.
> >
> > A trace of the source indicates that it comes from almost anywhere,
> > anytime.
> >
> > The fix is to return immediately if vc_mode != KD_TEXT.  The test is
> > placed in the following functions if not already present.
> >
> > fbcon_cursor()
> > fbcon_putcs()
> > fbcon_clear()
> > fbcon_bmove()
> > fbcon_blank()
>
> Since the exact same thing must be done if the fbdev are "asleep", can't

There is already a test that checks for console_blanked and FBINFO_STATE_RUNNING
in all of the above.  Yes, I can combine all three in one inline helper so it's cleaner.

Tony




-------------------------------------------------------
This SF.Net email is sponsored by:
Sybase ASE Linux Express Edition - download now for FREE
LinuxWorld Reader's Choice Award Winner for best database on Linux.
http://ads.osdn.com/?ad_id=5588&alloc_id=12065&op=click