From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] fbdev: workaround for broken X servers Date: Wed, 3 Nov 2004 16:01:10 +0200 Message-ID: <20041103140110.GA4555@sci.fi> References: <1099448020.900.25.camel@gaston> <20041103032613.GA3677@sci.fi> <200411032109.29734.adaplas@hotpop.com> Reply-To: linux-fbdev-devel@lists.sourceforge.net Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Return-path: Received: from sc8-sf-mx1-b.sourceforge.net ([10.3.1.11] helo=sc8-sf-mx1.sourceforge.net) by sc8-sf-list1.sourceforge.net with esmtp (Exim 4.30) id 1CPLhL-0003Ah-Ol for linux-fbdev-devel@lists.sourceforge.net; Wed, 03 Nov 2004 06:01:15 -0800 Received: from gw02.mail.saunalahti.fi ([195.197.172.116]) by sc8-sf-mx1.sourceforge.net with esmtp (Exim 4.41) id 1CPLhJ-0007y6-0F for linux-fbdev-devel@lists.sourceforge.net; Wed, 03 Nov 2004 06:01:15 -0800 Received: from kuori.saunalahti.fi (kuori.saunalahti.fi [195.197.175.23]) by gw02.mail.saunalahti.fi (Postfix) with ESMTP id A86744AB92 for ; Wed, 3 Nov 2004 16:01:10 +0200 (EET) Content-Disposition: inline In-Reply-To: <200411032109.29734.adaplas@hotpop.com> Sender: linux-fbdev-devel-admin@lists.sourceforge.net Errors-To: linux-fbdev-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Id: List-Post: List-Help: List-Subscribe: , List-Archive: Content-Type: text/plain; charset="iso-8859-1" To: linux-fbdev-devel@lists.sourceforge.net On Wed, Nov 03, 2004 at 09:09:29PM +0800, Antonino A. Daplas wrote: > On Wednesday 03 November 2004 11:26, Ville Syrj=E4l=E4 wrote: > > On Wed, Nov 03, 2004 at 01:13:39PM +1100, Benjamin Herrenschmidt wrot= e: > > > Hi ! > > > > > > + /* Workaround for broken X servers */ > > > + if (blank > VESA_POWERDOWN) > > > + blank =3D VESA_POWERDOWN; > > > + > > > if (info->fbops->fb_blank && !info->fbops->fb_blank(blank, info)) > > > return 0; > > > > This goes against documented behaviour (see fb.h). Also drivers/char/= vt.c > > seems to agree with fb.h, as do at least atyfb and matroxfb. I also u= sed > > the vesa level+1 convention in DirectFB. So AFAICS this patch would > > confuse console power management, XFree86/X.Org, DirectFB and some fb > > drivers. >=20 > True enough. The convention is if the display is active, then suspend. = If > it is suspended, then powerdown. And if already powered down, then do > nothing. It does so by by sending a blank flag of VESA_POWERDOWN + 1. >=20 > This is the convention used by the vt layer, I don't what is used by=20 > user apps. XFree86/X.Org and DirectFB both use vesa level+1. I'm not sure if there=20 are other userspace users. > The above patch won't break console power management as the console cal= ls > fbcon_blank(), not fb_blank(). But fbcon_blank() calls fb_blank() does it not? --=20 Ville Syrj=E4l=E4 syrjala@sci.fi http://www.sci.fi/~syrjala/ ------------------------------------------------------- This SF.Net email is sponsored by: Sybase ASE Linux Express Edition - download now for FREE LinuxWorld Reader's Choice Award Winner for best database on Linux. http://ads.osdn.com/?ad_id=5588&alloc_id=12065&op=click