From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yasushi SHOJI Subject: Re: [Linux-fbdev-devel] Re: [PATCH] fbdev: Fix IO access in rivafb Date: Sat, 13 Nov 2004 21:20:03 +0900 Message-ID: <20041113122003.0CA8A3E90C@dns1.atmark-techno.com> References: <200411080521.iA85LbG6025914@hera.kernel.org> <1099893447.10262.154.camel@gaston> <200411081706.55261.adaplas@hotpop.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: Cc: adaplas@pol.net, Linux Fbdev development list , Benjamin Herrenschmidt , Linux Kernel list , Andrew Morton , uClinux development list Hi Linus, At Mon, 8 Nov 2004 07:21:53 -0800 (PST), Linus Torvalds wrote: > > On Mon, 8 Nov 2004, Antonino A. Daplas wrote: > > > > How about this patch? This is almost the original macro in riva_hw.h, > > with the __force annotation. > > Why not just use __raw_readl/__raw_writel? > > That's what they exist for, and they still do any IO accesses correctly, > which a direct store does not do (it would seriously break on older > alphas, for example). sorry for a dumb question but should readl/writel on big endian system swap like ppc does? hmm... checking source code, it seems like most arch indeed does that, except m68knommu, h8300 and microblaze. is it nommu thing? -- yashi