On Wednesday 17 November 2004 19:07, Andrew Walrond wrote:
> On Wednesday 17 Nov 2004 00:33, Andrew Walrond wrote:
> > On Wednesday 17 Nov 2004 00:15, Antonino A. Daplas wrote:
> > > There was a bunch of IO access fixes in rivafb.  Can you narrow it down
> > > to a particular function?  Replace the following...
> > >
> > >  .fb_fillrect  = rivafb_fillrect,
>
> Broken.
>
> > >  .fb_copyarea  = rivafb_copyarea,
>
> seems ok
>
> > >  .fb_imageblit  = rivafb_imageblit,
>
> broken.
>

I was suspecting imageblit, I never suspected fillrect.  Anyway, can you try
the 2 patches attached.  The first patch reverts io access to the old method
(direct pointer loading/reading and forced alignment) and the second uses
__raw_{read|write} but forces alignment. You need to reverse the previous
patch before applying the other.

If none of the patches work, it will entail more work.  Revert the following
functions to linux-2.6.10-rc1, in the given order and preferrably one at a
time.

riva_set_pattern()
riva_set_rop_solid()
riva_setup_accel()
rivafb_imageblit()
rivafb_fillrect()

Tony