* [PATCH: 2.6.10-rc2] fbdev: Fix rivafb breakage (typo introduced by cset 1.2563)
@ 2004-11-18 12:39 Andrew Walrond
2004-11-18 12:55 ` Andrew Walrond
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Walrond @ 2004-11-18 12:39 UTC (permalink / raw)
To: Linus Torvalds; +Cc: Linux Frame Buffer Device Development, linux-kernel
Fix typo introduced during changes to use NV_ macros,
which caused screen corruption when using rivafb
signed-off-by: Andrew Walrond <andrew@walrond.org>
diff -Nru a/drivers/video/riva/riva_hw.c b/drivers/video/riva/riva_hw.c
--- a/drivers/video/riva/riva_hw.c 2004-11-18 12:32:15 +00:00
+++ b/drivers/video/riva/riva_hw.c 2004-11-18 12:32:15 +00:00
@@ -1556,7 +1556,7 @@
NV_WR32(chip->PGRAPH, 0x0000085C, state->pitch3);
NV_WR32(chip->PGRAPH, 0x00000860, state->pitch3);
NV_WR32(chip->PGRAPH, 0x00000864, state->pitch3);
- NV_WR32(chip->PGRAPH, 0x000009A, NV_RD32(chip->PFB, 0x00000200));
+ NV_WR32(chip->PGRAPH, 0x000009A4, NV_RD32(chip->PFB, 0x00000200));
NV_WR32(chip->PGRAPH, 0x000009A8, NV_RD32(chip->PFB, 0x00000204));
}
if(chip->twoHeads) {
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH: 2.6.10-rc2] fbdev: Fix rivafb breakage (typo introduced by cset 1.2563)
2004-11-18 12:39 [PATCH: 2.6.10-rc2] fbdev: Fix rivafb breakage (typo introduced by cset 1.2563) Andrew Walrond
@ 2004-11-18 12:55 ` Andrew Walrond
2004-11-18 23:06 ` Antonino A. Daplas
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Walrond @ 2004-11-18 12:55 UTC (permalink / raw)
To: linux-fbdev-devel; +Cc: Antonino A. Daplas, Linus Torvalds, linux-kernel
Fixing this typo cures the screen corruption I was seeing on both 32 and 64bit
x86_64 kernels.
Thanks for the help tracking this down. Please apply!
Andrew Walrond
-------------------------------------------------------
This SF.Net email is sponsored by: InterSystems CACHE
FREE OODBMS DOWNLOAD - A multidimensional database that combines
robust object and relational technologies, making it a perfect match
for Java, C++,COM, XML, ODBC and JDBC. www.intersystems.com/match8
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH: 2.6.10-rc2] fbdev: Fix rivafb breakage (typo introduced by cset 1.2563)
2004-11-18 12:55 ` Andrew Walrond
@ 2004-11-18 23:06 ` Antonino A. Daplas
0 siblings, 0 replies; 3+ messages in thread
From: Antonino A. Daplas @ 2004-11-18 23:06 UTC (permalink / raw)
To: linux-fbdev-devel, Andrew Walrond; +Cc: Linus Torvalds, linux-kernel
On Thursday 18 November 2004 20:55, Andrew Walrond wrote:
> Fixing this typo cures the screen corruption I was seeing on both 32 and
> 64bit x86_64 kernels.
>
> Thanks for the help tracking this down. Please apply!
>
No, thank _you_ for the help tracking this down :-)
Tony
-------------------------------------------------------
This SF.Net email is sponsored by: InterSystems CACHE
FREE OODBMS DOWNLOAD - A multidimensional database that combines
robust object and relational technologies, making it a perfect match
for Java, C++,COM, XML, ODBC and JDBC. www.intersystems.com/match8
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-11-18 23:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-11-18 12:39 [PATCH: 2.6.10-rc2] fbdev: Fix rivafb breakage (typo introduced by cset 1.2563) Andrew Walrond
2004-11-18 12:55 ` Andrew Walrond
2004-11-18 23:06 ` Antonino A. Daplas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).