linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Antonino Daplas <adaplas@pol.net>
Cc: linux-kernel@vger.kernel.org, linux-fbdev-devel@lists.sourceforge.net
Subject: Re: [2.6 patch] drivers/video/: misc cleanups
Date: Sun, 21 Nov 2004 16:58:11 +0100	[thread overview]
Message-ID: <20041121155811.GA2961@stusta.de> (raw)
In-Reply-To: <20041121153702.GB2829@stusta.de>

On Sun, Nov 21, 2004 at 04:37:02PM +0100, Adrian Bunk wrote:

> The patch below does the following cleanups under drivers/video/ :
> - make some needlessly global code static
> - the following was needlessly EXPORT_SYMBOL'ed:
>   - fbcon.c: fb_con
>   - mdacon.c: fb_blank
>   - fbmon.c: get_EDID_from_firmware (completely unused)
>...

I forgot one thing:

Please review my global_mode_option removal in modedb.c .

It was always NULL and I'd say the only usage was wrong (although it 
had no practical effect).

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

  reply	other threads:[~2004-11-21 15:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-21 15:37 [2.6 patch] drivers/video/: misc cleanups Adrian Bunk
2004-11-21 15:58 ` Adrian Bunk [this message]
2004-11-22  2:55   ` [Linux-fbdev-devel] " Antonino A. Daplas
2004-11-22  9:43     ` Geert Uytterhoeven
2004-11-22 20:46       ` Antonino A. Daplas
2004-11-22 21:33         ` Geert Uytterhoeven
2004-11-22  2:54 ` [Linux-fbdev-devel] " Antonino A. Daplas
  -- strict thread matches above, loose matches on Subject: below --
2005-02-11 19:10 Adrian Bunk
2005-02-24 11:10 Adrian Bunk
2005-03-12 22:26 Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041121155811.GA2961@stusta.de \
    --to=bunk@stusta.de \
    --cc=adaplas@pol.net \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).