From: "Antonino A. Daplas" <adaplas@hotpop.com>
To: Adrian Bunk <bunk@stusta.de>, Antonino Daplas <adaplas@pol.net>
Cc: linux-kernel@vger.kernel.org, linux-fbdev-devel@lists.sourceforge.net
Subject: Re: [Linux-fbdev-devel] Re: [2.6 patch] drivers/video/: misc cleanups
Date: Mon, 22 Nov 2004 10:55:06 +0800 [thread overview]
Message-ID: <200411221055.07693.adaplas@hotpop.com> (raw)
In-Reply-To: <20041121155811.GA2961@stusta.de>
On Sunday 21 November 2004 23:58, Adrian Bunk wrote:
> On Sun, Nov 21, 2004 at 04:37:02PM +0100, Adrian Bunk wrote:
> > The patch below does the following cleanups under drivers/video/ :
> > - make some needlessly global code static
> > - the following was needlessly EXPORT_SYMBOL'ed:
> > - fbcon.c: fb_con
> > - mdacon.c: fb_blank
> > - fbmon.c: get_EDID_from_firmware (completely unused)
> >...
>
> I forgot one thing:
>
> Please review my global_mode_option removal in modedb.c .
>
> It was always NULL and I'd say the only usage was wrong (although it
> had no practical effect).
Should be ok to remove it. I only see fb_find_mode using it, and as
you've concluded, usage is not very clear.
BTW: The global_mode_option, previously, is filled up when no driver is
specified in the boot options, such as "video=1024x768@60". But this was
removed during the fb initialization cleanup.
Tony
next prev parent reply other threads:[~2004-11-22 2:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-21 15:37 [2.6 patch] drivers/video/: misc cleanups Adrian Bunk
2004-11-21 15:58 ` Adrian Bunk
2004-11-22 2:55 ` Antonino A. Daplas [this message]
2004-11-22 9:43 ` Geert Uytterhoeven
2004-11-22 20:46 ` Antonino A. Daplas
2004-11-22 21:33 ` Geert Uytterhoeven
2004-11-22 2:54 ` [Linux-fbdev-devel] " Antonino A. Daplas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200411221055.07693.adaplas@hotpop.com \
--to=adaplas@hotpop.com \
--cc=adaplas@pol.net \
--cc=bunk@stusta.de \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).