From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Antonino A. Daplas" Subject: Re: Re: [2.6 patch] drivers/video/: misc cleanups Date: Tue, 23 Nov 2004 04:46:47 +0800 Message-ID: <200411230446.50784.adaplas@hotpop.com> References: <20041121153702.GB2829@stusta.de> <200411221055.07693.adaplas@hotpop.com> Reply-To: linux-fbdev-devel@lists.sourceforge.net Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: Received: from sc8-sf-mx1-b.sourceforge.net ([10.3.1.11] helo=sc8-sf-mx1.sourceforge.net) by sc8-sf-list1.sourceforge.net with esmtp (Exim 4.30) id 1CWL5j-0005H7-DK for linux-fbdev-devel@lists.sourceforge.net; Mon, 22 Nov 2004 12:47:19 -0800 Received: from smtp-out.hotpop.com ([38.113.3.61]) by sc8-sf-mx1.sourceforge.net with esmtp (Exim 4.41) id 1CWL5h-0003Md-U8 for linux-fbdev-devel@lists.sourceforge.net; Mon, 22 Nov 2004 12:47:19 -0800 Received: from hotpop.com (kubrick.hotpop.com [38.113.3.103]) by smtp-out.hotpop.com (Postfix) with SMTP id 35CEAA193C2 for ; Mon, 22 Nov 2004 20:47:05 +0000 (UTC) In-Reply-To: Content-Disposition: inline Sender: linux-fbdev-devel-admin@lists.sourceforge.net Errors-To: linux-fbdev-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Id: List-Post: List-Help: List-Subscribe: , List-Archive: Content-Type: text/plain; charset="us-ascii" To: linux-fbdev-devel@lists.sourceforge.net, Geert Uytterhoeven Cc: Adrian Bunk , Linux Kernel Development On Monday 22 November 2004 17:43, Geert Uytterhoeven wrote: > On Mon, 22 Nov 2004, Antonino A. Daplas wrote: > > On Sunday 21 November 2004 23:58, Adrian Bunk wrote: > > > On Sun, Nov 21, 2004 at 04:37:02PM +0100, Adrian Bunk wrote: > > > > The patch below does the following cleanups under drivers/video/ : > > > > - make some needlessly global code static > > > > - the following was needlessly EXPORT_SYMBOL'ed: > > > > - fbcon.c: fb_con > > > > - mdacon.c: fb_blank > > > > - fbmon.c: get_EDID_from_firmware (completely unused) > > > >... > > > > > > I forgot one thing: > > > > > > Please review my global_mode_option removal in modedb.c . > > > > > > It was always NULL and I'd say the only usage was wrong (although it > > > had no practical effect). > > > > Should be ok to remove it. I only see fb_find_mode using it, and as > > you've concluded, usage is not very clear. > > > > BTW: The global_mode_option, previously, is filled up when no driver is > > specified in the boot options, such as "video=1024x768@60". But this was > > removed during the fb initialization cleanup. > > What a pity... It allowed people to not have to care about the name of > their graphics driver(s)... > The absence of the driver name array will make it a bit difficult to differentiate between options passed specifically to drivers vs the global mode option. We can bring global_mode_option back. Since driver names always have a terminating "fb", we can search for the "fb:" substring and if not found, then it's a global_mode_option. Is that okay? Tony ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://productguide.itmanagersjournal.com/