Re: [PATCH] GeForce 5200 on rivafb

["Antonino A. Daplas" <adaplas@hotpop.com>]

[-- Attachment #1: Type: text/plain, Size: 1445 bytes --]

On Wednesday 08 December 2004 09:47, Lucas Correia Villa Real wrote:
> Hi,
>
> I was trying to figure out why my GeForce FX 5200 wasn't being recognized
> by rivafb, when I saw that its ID was not being included by the driver.
>
> The following patch (against 2.6.10-rc3) allows it to compile and switch to
> graphics mode successfully.

We haven't included the id's for NV30 chipsets and newer since the rivafb code
was made for NV20 and older cards.  So we add the id's only if users report that
it works.

>
> Just a note: the README file shipped with the NVIDIA driver has a complete
> list of device ID's. While it's easy to add them all into riva.c and
> pci_ids.h, I'm not very sure if it's okay to flood them with #defines and
> by increasing heavily the rivafb_pci_tbl table.
>
> Is it ok to do that, or were you waiting to get a feedback from users from
> those cards first? I can provide a patch to include all the missing cards
> if there's no problem on doing that.

Actually, I'm planning to replace/supplement the rivafb driver with nvidiafb
which will support NV30 and NV40 chipsets, including full acceleration as
well as better display detection.  If you don't mind, I'm going to attach the
patch for testing.  Usage is:

video=nvidiafb:<options>

where options are quite similar to rivafb's.

Patch should apply against recent 2.6 kernels, but it might choke on
include/linux/pci_ids.h. Let me know if it works for you.

Tony

[-- Attachment #2: nvidiafb.diff.gz --]
[-- Type: application/x-gzip, Size: 33665 bytes --]