[PATCH] pm2fb: fix fbi image display on 24 bit depth big endian

[PATCH] pm2fb: fix fbi image display on 24 bit depth big endian

[Jim Hague]

  Handle 24bit on big-endian by leaving the hardware in RGB and using the
  colour offset to reverse red/blue. Leaving the hardware in RGB means
  that fbi displays images correctly (abeit fortuitously) and the console
  is correct, thanks to a recent patch to the console code correcting
  an endian bug in fbcon_putc().

  Signed-off-by: Jim Hague <jim.hague@acm.org>

diff -rN -u linux-old/drivers/video/pm2fb.c linux-new/drivers/video/pm2fb.c
--- linux-old/drivers/video/pm2fb.c     2004-12-10 11:25:35.000000000 +0000
+++ linux-new/drivers/video/pm2fb.c     2004-12-08 19:53:35.000000000 +0000
@@ -646,12 +646,22 @@
        case 32:
                var->transp.offset = 24;
                var->transp.length = 8;
-       case 24:
                var->red.offset   = 16;
                var->green.offset = 8;
                var->blue.offset  = 0;
                var->red.length = var->green.length = var->blue.length = 8;
                break;
+       case 24:
+#ifdef __BIG_ENDIAN
+               var->red.offset   = 0;
+               var->blue.offset  = 16;
+#else
+               var->red.offset   = 16;
+               var->blue.offset  = 0;
+#endif
+               var->green.offset = 8;
+               var->red.length = var->green.length = var->blue.length = 8;
+               break;
        }
        var->height = var->width = -1;

@@ -789,10 +799,6 @@
        case 24:
                pm2_WR(par, PM2R_FB_READ_PIXEL, 4);
                clrmode |= PM2F_RD_TRUECOLOR | PM2F_RD_PIXELFORMAT_RGB888;
-#ifdef __BIG_ENDIAN
-               /* Use BGR not RGB */
-               clrmode &= ~PM2F_RD_COLOR_MODE_RGB;
-#endif
                txtmap = PM2F_TEXTEL_SIZE_24;
                pixsize = 4;
                clrformat = 0x20;


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/