linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guido Guenther <agx@sigxcpu.org>
To: linux-fbdev-devel@lists.sourceforge.net
Subject: Re: [PATCH] GeForce 5200 on rivafb
Date: Thu, 23 Dec 2004 21:48:21 +0100	[thread overview]
Message-ID: <20041223204819.GA25233@bogon.ms20.nix> (raw)
In-Reply-To: <200412072347.23194.lucasvr@gobolinux.org>

On Tue, Dec 07, 2004 at 11:47:23PM -0200, Lucas Correia Villa Real wrote:
> diff -X dontdiff-2.6 -Nur 2.6.10-rc3-vanilla/drivers/video/riva/fbdev.c 2.6.10-rc3-lucasvr/drivers/video/riva/fbdev.c
> --- 2.6.10-rc3-vanilla/drivers/video/riva/fbdev.c	2004-12-07 09:58:14.000000000 -0200
> +++ 2.6.10-rc3-lucasvr/drivers/video/riva/fbdev.c	2004-12-07 22:45:52.000000000 -0200
> @@ -192,6 +192,10 @@
>  	  PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 },
>  	{ PCI_VENDOR_ID_NVIDIA, PCI_DEVICE_ID_NVIDIA_QUADRO4_700XGL,
>  	  PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 },
> +	{ PCI_VENDOR_ID_NVIDIA, PCI_DEVICE_ID_NVIDIA_GEFORCE_FX_5200_ULTRA,
> +	  PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 },
> +	{ PCI_VENDOR_ID_NVIDIA, PCI_DEVICE_ID_NVIDIA_GEFORCE_FX_5200,
> +	  PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 },
>  	{ PCI_VENDOR_ID_NVIDIA, PCI_DEVICE_ID_NVIDIA_GEFORCE_FX_GO_5200,
>  	  PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 },
>  	{ 0, } /* terminate list */
> @@ -1876,6 +1880,8 @@
>  		case 0x0300:   /* GeForceFX 5800 */
>  		case 0x0310:   /* GeForceFX 5600 */
>  		case 0x0320:   /* GeForceFX 5200 */
> +		case 0x0321:   /* GeForceFX 5200 Ultra */
> +		case 0x0322:   /* GeForceFX 5200 */
>  		case 0x0330:   /* GeForceFX 5900 */
>  		case 0x0340:   /* GeForceFX 5700 */
>  		     arch =  NV_ARCH_30;
This last hunk is wrong, we do a (pd->device && 0x0ff0) above that, so
the 0x0321 and 0x322 parts are never possible.
 -- Guido


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/

  parent reply	other threads:[~2004-12-24 19:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-08  1:47 [PATCH] GeForce 5200 on rivafb Lucas Correia Villa Real
2004-12-08 12:34 ` Antonino A. Daplas
2004-12-10  1:46   ` Lucas Correia Villa Real
2004-12-10 20:43     ` Antonino A. Daplas
2004-12-11  3:34       ` Junio C Hamano
2004-12-23 20:48 ` Guido Guenther [this message]
  -- strict thread matches above, loose matches on Subject: below --
2004-12-11 15:22 Antonino A. Daplas
2004-12-11 18:21 ` Junio C Hamano
2004-12-11 21:11 Antonino A. Daplas
2004-12-12  2:25 ` Junio C Hamano
2004-12-12 10:00   ` Junio C Hamano
2004-12-13 20:52     ` Antonino A. Daplas
2004-12-13 21:47       ` Antonino A. Daplas
2004-12-14  7:51         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041223204819.GA25233@bogon.ms20.nix \
    --to=agx@sigxcpu.org \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).