* [PATCH] video/fbdev/wm8505fb: Delete an error message for a failed memory allocation in wm8505fb_pro @ 2017-11-24 19:30 ` SF Markus Elfring 2017-12-29 17:48 ` [PATCH] video/fbdev/wm8505fb: Delete an error message for a failed memory allocation in wm8505fb Bartlomiej Zolnierkiewicz 0 siblings, 1 reply; 2+ messages in thread From: SF Markus Elfring @ 2017-11-24 19:30 UTC (permalink / raw) To: dri-devel, linux-arm-kernel, linux-fbdev, Tony Prisk, Bartlomiej Zolnierkiewicz Cc: kernel-janitors, LKML From: Markus Elfring <elfring@users.sourceforge.net> Date: Fri, 24 Nov 2017 20:22:10 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/video/fbdev/wm8505fb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/video/fbdev/wm8505fb.c b/drivers/video/fbdev/wm8505fb.c index 253ffe9baab2..8f0d5379861d 100644 --- a/drivers/video/fbdev/wm8505fb.c +++ b/drivers/video/fbdev/wm8505fb.c @@ -276,10 +276,8 @@ static int wm8505fb_probe(struct platform_device *pdev) fbi = devm_kzalloc(&pdev->dev, sizeof(struct wm8505fb_info) + sizeof(u32) * 16, GFP_KERNEL); - if (!fbi) { - dev_err(&pdev->dev, "Failed to initialize framebuffer device\n"); + if (!fbi) return -ENOMEM; - } strcpy(fbi->fb.fix.id, DRIVER_NAME); -- 2.15.0 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] video/fbdev/wm8505fb: Delete an error message for a failed memory allocation in wm8505fb 2017-11-24 19:30 ` [PATCH] video/fbdev/wm8505fb: Delete an error message for a failed memory allocation in wm8505fb_pro SF Markus Elfring @ 2017-12-29 17:48 ` Bartlomiej Zolnierkiewicz 0 siblings, 0 replies; 2+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2017-12-29 17:48 UTC (permalink / raw) To: SF Markus Elfring Cc: dri-devel, linux-arm-kernel, linux-fbdev, Tony Prisk, LKML, kernel-janitors On Friday, November 24, 2017 08:30:04 PM SF Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Fri, 24 Nov 2017 20:22:10 +0100 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- > drivers/video/fbdev/wm8505fb.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/video/fbdev/wm8505fb.c b/drivers/video/fbdev/wm8505fb.c > index 253ffe9baab2..8f0d5379861d 100644 > --- a/drivers/video/fbdev/wm8505fb.c > +++ b/drivers/video/fbdev/wm8505fb.c > @@ -276,10 +276,8 @@ static int wm8505fb_probe(struct platform_device *pdev) > > fbi = devm_kzalloc(&pdev->dev, sizeof(struct wm8505fb_info) + > sizeof(u32) * 16, GFP_KERNEL); > - if (!fbi) { > - dev_err(&pdev->dev, "Failed to initialize framebuffer device\n"); > + if (!fbi) > return -ENOMEM; > - } This removes the information about the device for which the allocation fails (but as there can be only one wm8505fb device in the system this change is okay). Patch queued for 4.16, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-12-29 17:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20171124193022epcas5p2dddfdb636f02793037a470d0932ed6c4@epcas5p2.samsung.com>
2017-11-24 19:30 ` [PATCH] video/fbdev/wm8505fb: Delete an error message for a failed memory allocation in wm8505fb_pro SF Markus Elfring
2017-12-29 17:48 ` [PATCH] video/fbdev/wm8505fb: Delete an error message for a failed memory allocation in wm8505fb Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).