[PATCH 2.6] FB: Possible fbcon cleanups

[PATCH 2.6] FB: Possible fbcon cleanups

[Jean Delvare]

Hello,

While browsing the video/fbcon.c source file (Linux 2.6.10-rc3) I found
some possible cleanups. Patch follows, feel free to apply all or parts
of it if it looks OK to you.

Signed-off-by: Jean Delvare <khali@linux-fr.org>

--- linux-2.6.10-rc3/drivers/video/fbmon.c.orig	2004-10-24 09:48:34.000000000 +0200
+++ linux-2.6.10-rc3/drivers/video/fbmon.c	2004-12-24 16:18:18.000000000 +0100
@@ -66,10 +66,9 @@
 	},
 };
 
-const unsigned char edid_v1_header[] = { 0x00, 0xff, 0xff, 0xff,
+static const unsigned char edid_v1_header[] = { 0x00, 0xff, 0xff, 0xff,
 	0xff, 0xff, 0xff, 0x00
 };
-const unsigned char edid_v1_descriptor_flag[] = { 0x00, 0x00 };
 
 static void copy_string(unsigned char *c, unsigned char *s)
 {
@@ -632,7 +631,7 @@
 
 	fb_get_monitor_limits(edid, specs);
 
-	c = (block[0] & 0x80) >> 7;
+	c = block[0] & 0x80;
 	specs->input = 0;
 	if (c) {
 		specs->input |= FB_DISP_DDI;
@@ -656,13 +655,10 @@
 			DPRINTK("0.700V/0.000V");
 			specs->input |= FB_DISP_ANA_700_000;
 			break;
-		default:
-			DPRINTK("unknown");
-			specs->input |= FB_DISP_UNKNOWN;
 		}
 	}
 	DPRINTK("\n      Sync: ");
-	c = (block[0] & 0x10) >> 4;
+	c = block[0] & 0x10;
 	if (c)
 		DPRINTK("      Configurable signal level\n");
 	c = block[0] & 0x0f;


-- 
Jean Delvare
http://khali.linux-fr.org/

Re: [PATCH 2.6] FB: Possible fbcon cleanups

[Antonino A. Daplas]

On Sunday 26 December 2004 22:13, Jean Delvare wrote:
> Hello,
>
> While browsing the video/fbcon.c source file (Linux 2.6.10-rc3) I found
> some possible cleanups. Patch follows, feel free to apply all or parts
> of it if it looks OK to you.
>

Looks good, thanks.

Tony