[patch] video/i810: module_param fixes

[patch] video/i810: module_param fixes

[Domen Puncer]

Last parameter is file permition in sysfs, not default value.
(If 0, file is not accessible trough sysfs, and that's what i did.)


Signed-off-by: Domen Puncer <domen@coderock.org>

--- c/drivers/video/i810/i810_main.c	2004-12-25 15:50:20.000000000 +0100
+++ a/drivers/video/i810/i810_main.c	2004-12-29 10:43:05.000000000 +0100
@@ -2002,20 +2002,20 @@ int __init i810fb_init(void)
 	return pci_register_driver(&i810fb_driver);
 }
 
-module_param(vram, int, 4);
+module_param(vram, int, 0);
 MODULE_PARM_DESC(vram, "System RAM to allocate to framebuffer in MiB" 
 		 " (default=4)");
 module_param(voffset, int, 0);
 MODULE_PARM_DESC(voffset, "at what offset to place start of framebuffer "
                  "memory (0 to maximum aperture size), in MiB (default = 48)");
-module_param(bpp, int, 8);
+module_param(bpp, int, 0);
 MODULE_PARM_DESC(bpp, "Color depth for display in bits per pixel"
 		 " (default = 8)");
-module_param(xres, int, 640);
+module_param(xres, int, 0);
 MODULE_PARM_DESC(xres, "Horizontal resolution in pixels (default = 640)");
-module_param(yres, int, 480);
+module_param(yres, int, 0);
 MODULE_PARM_DESC(yres, "Vertical resolution in scanlines (default = 480)");
-module_param(vyres,int, 480);
+module_param(vyres,int, 0);
 MODULE_PARM_DESC(vyres, "Virtual vertical resolution in scanlines"
 		 " (default = 480)");
 module_param(hsync1, int, 0);


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/

Re: [patch] video/i810: module_param fixes

[Antonino A. Daplas]

On Wednesday 29 December 2004 17:47, Domen Puncer wrote:
> Last parameter is file permition in sysfs, not default value.
> (If 0, file is not accessible trough sysfs, and that's what i did.)
>
>
> Signed-off-by: Domen Puncer <domen@coderock.org>

Thank you for the fix.

Tony




-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt