* [patch 1/3] video/pxafb: reorder add_wait_queue() and set_current_state()
@ 2005-01-10 19:42 domen
0 siblings, 0 replies; only message in thread
From: domen @ 2005-01-10 19:42 UTC (permalink / raw)
To: adaplas; +Cc: linux-fbdev-devel, domen, nacc
Any comments would be, as always, appreciated.
-Nish
Description: Reorder set_current_state() and add_wait_queue(). There is
a chance that a signal could be missed in between the two functions
currently.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
Signed-off-by: Domen Puncer <domen@coderock.org>
---
kj-domen/drivers/video/pxafb.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
diff -puN drivers/video/pxafb.c~reorder-state-drivers_video_pxafb drivers/video/pxafb.c
--- kj/drivers/video/pxafb.c~reorder-state-drivers_video_pxafb 2005-01-10 18:00:25.000000000 +0100
+++ kj-domen/drivers/video/pxafb.c 2005-01-10 18:00:25.000000000 +0100
@@ -740,8 +740,8 @@ static void pxafb_disable_controller(str
DPRINTK("Disabling LCD controller\n");
- add_wait_queue(&fbi->ctrlr_wait, &wait);
set_current_state(TASK_UNINTERRUPTIBLE);
+ add_wait_queue(&fbi->ctrlr_wait, &wait);
LCSR = 0xffffffff; /* Clear LCD Status Register */
LCCR0 &= ~LCCR0_LDM; /* Enable LCD Disable Done Interrupt */
_
-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2005-01-10 19:42 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-01-10 19:42 [patch 1/3] video/pxafb: reorder add_wait_queue() and set_current_state() domen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).