From: domen@coderock.org
To: adaplas@pol.net
Cc: linux-fbdev-devel@lists.sourceforge.net, domen@coderock.org,
nacc@us.ibm.com
Subject: [patch 2/3] video/sa1100fb: reorder set_current_state() and add_wait_queue()
Date: Mon, 10 Jan 2005 20:42:05 +0100 [thread overview]
Message-ID: <20050110194205.EB4151F208@trashy.coderock.org> (raw)
Any comments would be, as always, appreciated.
-Nish
Description: Reorder add_wait_queue() and set_current_state() as a
signal could be lost in between the two functions.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
Signed-off-by: Domen Puncer <domen@coderock.org>
---
kj-domen/drivers/video/sa1100fb.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
diff -puN drivers/video/sa1100fb.c~reorder-state-drivers_video_sa1100fb drivers/video/sa1100fb.c
--- kj/drivers/video/sa1100fb.c~reorder-state-drivers_video_sa1100fb 2005-01-10 18:00:25.000000000 +0100
+++ kj-domen/drivers/video/sa1100fb.c 2005-01-10 18:00:25.000000000 +0100
@@ -1072,8 +1072,8 @@ static void sa1100fb_disable_controller(
GPCR |= SHANNON_GPIO_DISP_EN;
}
- add_wait_queue(&fbi->ctrlr_wait, &wait);
set_current_state(TASK_UNINTERRUPTIBLE);
+ add_wait_queue(&fbi->ctrlr_wait, &wait);
LCSR = 0xffffffff; /* Clear LCD Status Register */
LCCR0 &= ~LCCR0_LDM; /* Enable LCD Disable Done Interrupt */
_
-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt
reply other threads:[~2005-01-10 19:42 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050110194205.EB4151F208@trashy.coderock.org \
--to=domen@coderock.org \
--cc=adaplas@pol.net \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=nacc@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).