[Bugme-new] [Bug 4047] New: kerenl failt to kompile

[Bugme-new] [Bug 4047] New: kerenl failt to kompile

[Andrew Zabolotny]

[-- Attachment #1: Type: text/plain, Size: 751 bytes --]

Hello!

> Date: Sun, 16 Jan 2005 03:14:57 -0800
> From: bugme-daemon@osdl.org
> To: bugme-new@lists.osdl.org
> Subject: [Bugme-new] [Bug 4047] New: kerenl failt to kompile
>
> http://bugme.osdl.org/show_bug.cgi?id=4047
>
>           Summary: kerenl failt to kompile
>    Kernel Version: 2.6.11-rc1-mm1
>            Status: NEW
>          Severity: blocking
>             Owner: jsimmons@infradead.org
>         Submitter: bug-track@fisher-privat.net
>
>
> Distribution:Debian Sarge
>
> Problem Description:
> LD      init/built-in.o
>  LD      .tmp_vmlinux1
> drivers/built-in.o(.text+0x9bfa): In function `lcd_device_register':
> : undefined reference to `fb_register_client'
Here's an obvious fix plus a minor enhancement.

-- 
Greetings,
   Andrew

[-- Attachment #2: tiny-fix.diff --]
[-- Type: text/x-patch, Size: 1275 bytes --]

Index: Kconfig
===================================================================
RCS file: /cvs/linux/kernel26/drivers/video/Kconfig,v
retrieving revision 1.37
diff -u -r1.37 Kconfig
--- Kconfig	2 Jan 2005 20:17:25 -0000	1.37
+++ Kconfig	16 Jan 2005 21:41:40 -0000
@@ -1168,7 +1168,7 @@
 	source "drivers/video/logo/Kconfig"
 endif
 
-if SYSFS
+if FB && SYSFS
 	source "drivers/video/backlight/Kconfig"
 endif
 
Index: backlight/Kconfig
===================================================================
RCS file: /cvs/linux/kernel26/drivers/video/backlight/Kconfig,v
retrieving revision 1.1
diff -u -r1.1 Kconfig
--- backlight/Kconfig	2 Jan 2005 20:17:25 -0000	1.1
+++ backlight/Kconfig	16 Jan 2005 21:41:40 -0000
@@ -11,6 +11,7 @@
 config BACKLIGHT_CLASS_DEVICE
         tristate "Lowlevel Backlight controls"
 	depends on BACKLIGHT_LCD_SUPPORT
+	default m
 	help
 	  This framework adds support for low-level control of the LCD
           backlight. This includes support for brightness and power.
@@ -26,6 +27,7 @@
 config LCD_CLASS_DEVICE
         tristate "Lowlevel LCD controls"
 	depends on BACKLIGHT_LCD_SUPPORT
+	default m
 	help
 	  This framework adds support for low-level control of LCD.
 	  Some framebuffer devices connect to platform-specific LCD modules

Re: [Bugme-new] [Bug 4047] New: kerenl failt to kompile

[Antonino A. Daplas]

On Monday 17 January 2005 05:41, Andrew Zabolotny wrote:
> Hello!
>
> > Date: Sun, 16 Jan 2005 03:14:57 -0800
> > From: bugme-daemon@osdl.org
> > To: bugme-new@lists.osdl.org
> > Subject: [Bugme-new] [Bug 4047] New: kerenl failt to kompile
> >
> > http://bugme.osdl.org/show_bug.cgi?id=4047
> >
> >           Summary: kerenl failt to kompile
> >    Kernel Version: 2.6.11-rc1-mm1
> >            Status: NEW
> >          Severity: blocking
> >             Owner: jsimmons@infradead.org
> >         Submitter: bug-track@fisher-privat.net
> >
> >
> > Distribution:Debian Sarge
> >
> > Problem Description:
> > LD      init/built-in.o
> >  LD      .tmp_vmlinux1
> >
> > drivers/built-in.o(.text+0x9bfa): In function `lcd_device_register':
> > : undefined reference to `fb_register_client'
>
> Here's an obvious fix plus a minor enhancement.

Would it be better if backlight/lcd support is not fully dependent on the
framebuffer? 

It's your call, so I'm still submitting this patch to akpm.

Tony 




-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt

Re: [Bugme-new] [Bug 4047] New: kerenl failt to kompile

[Andrew Zabolotny]

On Tue, 18 Jan 2005 05:04:04 +0800
"Antonino A. Daplas" <adaplas@hotpop.com> wrote:

> > Here's an obvious fix plus a minor enhancement.
> Would it be better if backlight/lcd support is not fully dependent on
> the framebuffer? 
> It's your call, so I'm still submitting this patch to akpm.
I thought about it, but I don't see a lot of reasons for having
backlight without the framebuffer. Theoretically the FB-related stuff
could be enclosed within #if FB's but it would clutter the code. If
somebody will have a real reason for it, I think he'll quickly find out
how this can be achieved.

-- 
Greetings,
   Andrew


-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt