linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Antonino A. Daplas" <adaplas@hotpop.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Linux Fbdev development list
	<linux-fbdev-devel@lists.sourceforge.net>,
	Stuart_Hayes@Dell.com
Subject: [PATCH 2/6] vesafb: Change return error id
Date: Tue, 18 Jan 2005 05:41:05 +0800	[thread overview]
Message-ID: <200501180541.05366.adaplas@hotpop.com> (raw)

From: <Stuart_Hayes@Dell.com>

  I'm getting a message in dmesg:  "localhost kernel: vesafb: probe of
  vesafb0 failed with error -6"

  I searched the web, and found that a lot of people are getting this, but
  I couldn't find an answer, so I looked into it.

  This appears to be because "vesafb" returns -ENXIO ("No such device or
  address") when its probe function fails.  However, driverse/base/bus.c
  spews an error message during device_attach() if a matching driver's
  probe function returns anything but -ENODEV ("No such device").

Signed-off-by: Antonino Daplas <adaplas@pol.net>
---

 vesafb.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff -Nru a/drivers/video/vesafb.c b/drivers/video/vesafb.c
--- a/drivers/video/vesafb.c	2004-11-10 07:24:23 +08:00
+++ b/drivers/video/vesafb.c	2005-01-15 08:13:00 +08:00
@@ -229,7 +229,7 @@
 	unsigned int size_total;
 
 	if (screen_info.orig_video_isVGA != VIDEO_TYPE_VLFB)
-		return -ENXIO;
+		return -ENODEV;
 
 	vesafb_fix.smem_start = screen_info.lfb_base;
 	vesafb_defined.bits_per_pixel = screen_info.lfb_depth;
@@ -407,7 +407,7 @@
 		(ypan) ? FBINFO_HWACCEL_YPAN : 0;
 
 	if (fb_alloc_cmap(&info->cmap, 256, 0) < 0) {
-		err = -ENXIO;
+		err = -ENOMEM;
 		goto err;
 	}
 	if (register_framebuffer(info)<0) {




-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt

                 reply	other threads:[~2005-01-17 21:43 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200501180541.05366.adaplas@hotpop.com \
    --to=adaplas@hotpop.com \
    --cc=Stuart_Hayes@Dell.com \
    --cc=akpm@osdl.org \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).