From: "Antonino A. Daplas" <adaplas@swissinfo.org>
To: linux-fbdev-devel@lists.sourceforge.net
Subject: Re: [PATCH] skeletonfb
Date: Sat, 5 Feb 2005 05:57:46 +0800 [thread overview]
Message-ID: <200502050557.46676.adaplas@swissinfo.org> (raw)
In-Reply-To: <200501301911.17552.lucasvr@gobolinux.org>
On Monday 31 January 2005 05:11, Lucas Correia Villa Real wrote:
> Hi,
>
> This patch just fixes some typos and adds retval documentation for some
> functions that were missing it.
>
> I've also a question here: skeletonfb says that xxxfb_setcolreg() should
> return a negative errno on error. However, if the register number being
> accessed is out of bounds, 1 is returned. Shouldn't it be better to return
> -EINVAL instead? By looking at fbcmap.c, the retval isn't being checked
> against positive/negative values, so it doesn't make sense to return 1.
>
> Thanks,
Please, add a "Signed-off-by:" line next time.
Tony
-------------------------------------------------------
This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting
Tool for open source databases. Create drag-&-drop reports. Save time
by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc.
Download a FREE copy at http://www.intelliview.com/go/osdn_nl
prev parent reply other threads:[~2005-02-04 22:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-30 21:11 [PATCH] skeletonfb Lucas Correia Villa Real
2005-01-31 19:28 ` James Simmons
2005-02-04 21:57 ` Antonino A. Daplas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200502050557.46676.adaplas@swissinfo.org \
--to=adaplas@swissinfo.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).