Re: [patch] (Preliminary) Geode framebuffer driver.

["Antonino A. Daplas" <adaplas@hotpop.com>]

On Friday 11 February 2005 19:11, David Vrabel wrote:
> Hi,
>
> Attached is a patch (against 2.6.10) for a framebuffer driver for the
> Geode family of processors.  It does not use AMD's horrible Durango API.
>  It is, however, rather feature incomplete at the moment.
>
> 	* Only Geode GX1 (with CS5530 companion chip) is supported.
> 	* Tested resolutions: 640x480 to 1280x1024.
> 	* Supported bit depths: 8 bit palette, 16 bit RGB 5-6-5.
> 	* CRT output only.
> 	* No accelerated features.
> 	* Compression is not enabled.
>
> (Flat panel support and compression will likely be added next week, and
> acceleration after that.)
>
> Could this patch be considered for inclusion, please?

Yes.

However, I would prefer that instead of:

struct geodefb_info {
    	struct fb_info fb;
	...

use struct fb_info.par for all driver private data and use
framebuffer_release()/framebuffer_alloc() to de/allocate the fb_info
structure.

You can also make the check_var() function less strict.  You can
attempt to round up values instead of returning -EINVAL.

Tony




-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click