Re: [patch] (Preliminary) Geode framebuffer driver.

["Antonino A. Daplas" <adaplas@hotpop.com>]

On Tuesday 15 February 2005 19:13, David Vrabel wrote:
> Antonino A. Daplas wrote:
> > On Friday 11 February 2005 19:11, David Vrabel wrote:
> >>Attached is a patch (against 2.6.10) for a framebuffer driver for the
> >>Geode family of processors.  It does not use AMD's horrible Durango API.
> >> It is, however, rather feature incomplete at the moment.
> >>
> >>	* Only Geode GX1 (with CS5530 companion chip) is supported.
> >>	* Tested resolutions: 640x480 to 1280x1024.
> >>	* Supported bit depths: 8 bit palette, 16 bit RGB 5-6-5.
> >>	* CRT output only.
> >>	* No accelerated features.
> >>	* Compression is not enabled.
> >>
> >>Could this patch be considered for inclusion, please?
> >
> > Yes.
> >
> > However, I would prefer that instead of:
> >
> > struct geodefb_info {
> >     	struct fb_info fb;
> > 	...
> >
> > use struct fb_info.par for all driver private data and use
> > framebuffer_release()/framebuffer_alloc() to de/allocate the fb_info
> > structure.
>
> Done this now.  An updated patch is attached.
>
> This also includes a number of other changes:
>
>   - now works when built into the kernel
>   - flat panel support (panel=<x>x<y> option). (Only one 640x480 panel
>     has been tested though.)
>   - blank function for display blanking/powersaving.
>   - crt=<n> option to enable/disable the CRT output.
>
> David Vrabel

A few minor comments:

+        /* Clear the frame buffer of garbage. */
+        memset(info->screen_base, 0, info->fix.smem_len);

Is the above really necessary?  And if it is, memset_io is preferred.

+	info->screen_base = (unsigned char *)ioremap(info->fix.smem_start, info->fix.smem_len);

You also do not need the (unsigned char *) part. (sparse will complain.)

No need to resend the patch, just let me know what changes you want, if any.

Tony




-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click