From: "Antonino A. Daplas" <adaplas@hotpop.com>
To: linux-fbdev-devel@lists.sourceforge.net,
David Vrabel <dvrabel@arcom.com>
Subject: Re: [PATCH 2/7] fbdev: Make fb_find_mode() return failure if modular
Date: Fri, 18 Feb 2005 05:07:26 +0800 [thread overview]
Message-ID: <200502180507.32473.adaplas@hotpop.com> (raw)
In-Reply-To: <4214AA55.3000006@arcom.com>
On Thursday 17 February 2005 22:29, David Vrabel wrote:
> Antonino A. Daplas wrote:
> > A few drivers call fb_find_mode() even if compiled as a module. If the
> > modedb parameter is NULL, the function will use default modedb array
> > which is marked __init. This will cause a crash. To avoid this, check if
> > the driver is compiled as a module, and if it is, fail.
>
> Why limit the default mode DB to built-in drivers only?
The default db is used by drivers only once. After that, it just consumes
memory.
Tony
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
next prev parent reply other threads:[~2005-02-17 21:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-17 12:47 [PATCH 2/7] fbdev: Make fb_find_mode() return failure if modular Antonino A. Daplas
2005-02-17 14:29 ` David Vrabel
2005-02-17 21:07 ` Antonino A. Daplas [this message]
2005-02-17 22:09 ` James Simmons
2005-02-17 23:38 ` Antonino A. Daplas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200502180507.32473.adaplas@hotpop.com \
--to=adaplas@hotpop.com \
--cc=dvrabel@arcom.com \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).