From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Antonino A. Daplas" Subject: Re: [PATCH 2/7] fbdev: Make fb_find_mode() return failure if modular Date: Fri, 18 Feb 2005 05:07:26 +0800 Message-ID: <200502180507.32473.adaplas@hotpop.com> References: <200502172045.16677.adaplas@hotpop.com> <4214AA55.3000006@arcom.com> Reply-To: linux-fbdev-devel@lists.sourceforge.net Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Received: from sc8-sf-mx1-b.sourceforge.net ([10.3.1.11] helo=sc8-sf-mx1.sourceforge.net) by sc8-sf-list1.sourceforge.net with esmtp (Exim 4.30) id 1D1stl-00063S-Sb for linux-fbdev-devel@lists.sourceforge.net; Thu, 17 Feb 2005 13:09:21 -0800 Received: from smtp-out.hotpop.com ([38.113.3.61]) by sc8-sf-mx1.sourceforge.net with esmtp (Exim 4.41) id 1D1stj-0004QD-5M for linux-fbdev-devel@lists.sourceforge.net; Thu, 17 Feb 2005 13:09:21 -0800 Received: from hotpop.com (kubrick.hotpop.com [38.113.3.103]) by smtp-out.hotpop.com (Postfix) with SMTP id 4DB5BE5092D for ; Thu, 17 Feb 2005 21:09:02 +0000 (UTC) In-Reply-To: <4214AA55.3000006@arcom.com> Content-Disposition: inline Sender: linux-fbdev-devel-admin@lists.sourceforge.net Errors-To: linux-fbdev-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Id: List-Post: List-Help: List-Subscribe: , List-Archive: Content-Type: text/plain; charset="us-ascii" To: linux-fbdev-devel@lists.sourceforge.net, David Vrabel On Thursday 17 February 2005 22:29, David Vrabel wrote: > Antonino A. Daplas wrote: > > A few drivers call fb_find_mode() even if compiled as a module. If the > > modedb parameter is NULL, the function will use default modedb array > > which is marked __init. This will cause a crash. To avoid this, check if > > the driver is compiled as a module, and if it is, fail. > > Why limit the default mode DB to built-in drivers only? The default db is used by drivers only once. After that, it just consumes memory. Tony ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click