From: "Antonino A. Daplas" <adaplas@hotpop.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Olaf Hering <olh@suse.de>
Cc: Linus Torvalds <torvalds@osdl.org>,
Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Fbdev development list
<linux-fbdev-devel@lists.sourceforge.net>
Subject: Re: [Linux-fbdev-devel] Re: 2.6.11-rc5
Date: Sat, 26 Feb 2005 15:41:47 +0800 [thread overview]
Message-ID: <200502261541.49187.adaplas@hotpop.com> (raw)
In-Reply-To: <1109380389.15026.112.camel@gaston>
On Saturday 26 February 2005 09:13, Benjamin Herrenschmidt wrote:
> On Sat, 2005-02-26 at 01:41 +0100, Olaf Hering wrote:
> > modedb can not be __init because fb_find_mode() may get db == NULL.
> > fb_find_mode() is called from modules.
>
> Ahhh, good catch ! I though that was fixed long ago, looks like I was
> wrong.
The 2.4 fix was for fb_find_mode to always return 640x480 if modular.
There's no fix yet for 2.6 except for the patch which is already in the mm
tree, which is for fb_find_mode() to always fail if driver is compiled as a
module. (patch below).
Both fixes will still crash if fb_find_mode() is called again, so this
function is really designed to be called only once.
As for the other patch that removes the __init from modedb, some of the
developers might disagree.
Olaf,
Can you send me your EDID block? You can use read-edid. Your monitor
may have a fixable EDID and can be a candidate for the broken display
database.
Tony
next prev parent reply other threads:[~2005-02-26 7:41 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.LNX.4.58.0502232014190.18997@ppc970.osdl.org>
[not found] ` <20050224145049.GA21313@suse.de>
[not found] ` <1109287708.15026.25.camel@gaston>
[not found] ` <20050225070813.GA13735@suse.de>
[not found] ` <1109316551.14993.63.camel@gaston>
2005-02-25 17:29 ` 2.6.11-rc5 Olaf Hering
2005-02-25 17:59 ` [Linux-fbdev-devel] 2.6.11-rc5 James Simmons
2005-02-25 20:24 ` Olaf Hering
2005-02-25 21:21 ` [Linux-fbdev-devel] " Olaf Hering
2005-02-25 23:30 ` Olaf Hering
2005-02-26 1:01 ` Benjamin Herrenschmidt
2005-02-26 9:52 ` Giuseppe Bilotta
2005-02-26 0:58 ` Benjamin Herrenschmidt
2005-02-26 0:57 ` Benjamin Herrenschmidt
2005-02-26 0:54 ` 2.6.11-rc5 Benjamin Herrenschmidt
2005-02-26 0:41 ` 2.6.11-rc5 Olaf Hering
2005-02-26 0:49 ` 2.6.11-rc5 Linus Torvalds
2005-02-26 0:53 ` 2.6.11-rc5 Olaf Hering
2005-02-26 1:04 ` 2.6.11-rc5 Linus Torvalds
2005-02-26 1:08 ` 2.6.11-rc5 Buttchereit, Axel (XL)
2005-02-26 1:17 ` [Linux-fbdev-devel] " Benjamin Herrenschmidt
2005-02-26 1:13 ` 2.6.11-rc5 Benjamin Herrenschmidt
2005-02-26 7:41 ` Antonino A. Daplas [this message]
2005-02-27 8:07 ` 2.6.11-rc5 Geert Uytterhoeven
2005-02-27 20:32 ` 2.6.11-rc5, rivafb i2c oops, bogus error handling Olaf Hering
2005-02-28 14:41 ` Antonino A. Daplas
2005-03-01 12:02 ` [Linux-fbdev-devel] " Olaf Hering
2005-03-01 20:58 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200502261541.49187.adaplas@hotpop.com \
--to=adaplas@hotpop.com \
--cc=adaplas@pol.net \
--cc=benh@kernel.crashing.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=olh@suse.de \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).