linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: adaplas@pol.net
Cc: linux-fbdev-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: RFC: disallow modular framebuffers
Date: Thu, 3 Mar 2005 17:56:49 +0100	[thread overview]
Message-ID: <20050303165649.GF4608@stusta.de> (raw)
In-Reply-To: <200503012115.29023.adaplas@hotpop.com>

On Tue, Mar 01, 2005 at 09:15:27PM +0800, Antonino A. Daplas wrote:
> On Tuesday 01 March 2005 10:41, Adrian Bunk wrote:
> > Hi,
> >
> > while looking how to fix modular FB_SAVAGE_* (both FB_SAVAGE_I2C=m and
> > FB_SAVAGE_ACCEL=m are currently broken) I asked myself:
> 
> BTW, what's the problem with the above?

  #if defined(CONFIG_FB_SAVAGE_ACCEL)

doesn't work with FB_SAVAGE_ACCEL=m, and

  #if defined(CONFIG_FB_SAVAGE_ACCEL) || defined(CONFIG_FB_SAVAGE_ACCEL_MODULE)

would break with FB_SAVAGE=y and FB_SAVAGE_ACCEL=m.


Is there any reason for these being three modules?
It seems the best solution would be to make this one module composed of 
up to three object files?


> Tony

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

  reply	other threads:[~2005-03-03 16:56 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-01  2:41 RFC: disallow modular framebuffers Adrian Bunk
2005-03-01  3:46 ` Jeff Garzik
2005-03-01  6:07   ` Jon Smirl
2005-03-01 17:52     ` [Linux-fbdev-devel] " James Simmons
2005-03-01 12:49 ` [Linux-fbdev-devel] " Antonino A. Daplas
2005-03-01 13:15 ` Antonino A. Daplas
2005-03-03 16:56   ` Adrian Bunk [this message]
2005-03-03 19:50     ` Antonino A. Daplas
2005-03-03 20:20       ` Adrian Bunk
2005-03-03 20:37         ` Antonino A. Daplas
2005-03-03 23:07           ` [2.6 patch] make savagefb one module Adrian Bunk
2005-03-04  9:17             ` [Linux-fbdev-devel] " Geert Uytterhoeven
2005-03-05  1:12               ` Adrian Bunk
2005-03-05 20:49                 ` Antonino A. Daplas
2005-03-01 16:59 ` RFC: disallow modular framebuffers Jesse Barnes
2005-03-02 11:32 ` [Linux-fbdev-devel] " David Vrabel
2005-03-02 12:17 ` Paul Mundt
2005-03-02 18:01   ` Jon Smirl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050303165649.GF4608@stusta.de \
    --to=bunk@stusta.de \
    --cc=adaplas@pol.net \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).