linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kronos <kronos@people.it>
To: linux-fbdev-devel@lists.sourceforge.net
Cc: Andrew Morton <akpm@osdl.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: [PATCH] radeonfb: DDC i2c fix
Date: Fri, 11 Mar 2005 21:13:26 +0100	[thread overview]
Message-ID: <20050311201326.GA7379@dreamland.darkstar.lan> (raw)
In-Reply-To: <1110519970.5751.17.camel@gaston>

Il Fri, Mar 11, 2005 at 04:46:10PM +1100, Benjamin Herrenschmidt ha scritto: 
> The radeonfb code for DDC probing (like it's X.org counterpart) uses to
> leave the DDC clock & data lines asserted after the probing is complete.
> This causes problems with some Apple monitors like the new Cinema HD
> 23", who will turn themselves off when that happens. This fixes it.

Fix is correct, but comment is not ;) After the loop SCL and SDA are
left low. Pulling them high puts the I2C bus in the stop condition.

Luca
-- 
Home: http://kronoz.cjb.net
Inquietudine sintetica
Solo, davanti all'ignoto
Tienimi stretto a te


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click

  reply	other threads:[~2005-03-11 20:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-11  5:46 [PATCH] radeonfb: DDC i2c fix Benjamin Herrenschmidt
2005-03-11 20:13 ` Kronos [this message]
2005-03-11 23:52   ` Benjamin Herrenschmidt
2005-03-12  1:06     ` Kronos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050311201326.GA7379@dreamland.darkstar.lan \
    --to=kronos@people.it \
    --cc=akpm@osdl.org \
    --cc=benh@kernel.crashing.org \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).