Re: Re: Fw: [PATCH][2.6.11-mm3] CONFIG_FB_ATY linkage error on PPC32

["Antonino A. Daplas" <adaplas@hotpop.com>]

On Monday 14 March 2005 07:14, Andrew Morton wrote:
> Jon Smirl <jonsmirl@gmail.com> wrote:
> > This should be a more general fix. Mikael can you give it a try on ppc
> >  since I don't have one?
> >
> >  If you have time it would also be helpful if you could try building
> >  all of the ppc drivers both as modules and built-in just to make sure
> >  they build.
> >
> >  There are 77 framebuffer drivers on eight platforms that need to be
> >  checked. I tried to get them all right but I don't own all of the
> >  needed hardware.
>
> Confused.  Is Tony's patch OK?
>
> >  ===== drivers/video/Makefile 1.120 vs edited =====
> >  --- 1.120/drivers/video/Makefile	2005-03-10 03:39:10 -05:00
> >  +++ edited/drivers/video/Makefile	2005-03-13 16:56:53 -05:00
> >  @@ -10,6 +10,9 @@
> >
> >   obj-$(CONFIG_FB)                  += fb.o
> >   fb-y                              := fbmem.o fbmon.o fbcmap.o
> >  fbsysfs.o modedb.o
> >  +ifdef $(CONFIG-PPC)
> >  +fb-y				  += macmodes.o
> >  +endif

The problem with generalizing macmodes under CONFIG_PPC is that not all
PPC-based drivers will use macmodes. While most depend on PPC, some require
PPC_OF, and others PPC_PMAC. It's more flexible if each driver does the
selection.

Tony




-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click