Re: Re: [PATCH][RFC] Add support for Epson S1D13806 FB

[Thibaut VARENE <varenet@esiee.fr>]

-------------------
> On Mon, 14 Mar 2005, Paul Mundt wrote:
> > On Mon, Mar 14, 2005 at 08:15:13PM +0800, Antonino A. Daplas
wrote:
> > > 3. You can use pci_resource_len()/pci_resource_start() instead
of
> > > 
> > > +	info->fix.mmio_start = pdev->resource[1].start;
> > > +	info->fix.mmio_len = pdev->resource[1].end -
pdev->resource[1].start;
> 
> +1?
> 
> > > +	info->fix.smem_start = pdev->resource[0].start;
> > > +	info->fix.smem_len = pdev->resource[0].end -
pdev->resource[0].start;
> 
> +1?
> 
> > > +
> > > 
> > No, the pdev here refers to a platform device, not a pci device.
> > 
> > While the pci_resource_xxx() routines would still technically do
the
> > right thing, this is purely coincidental.
> 
> Nah, they would work better here, since they do include the +1 ;-)

Good point. Actually that's a bad thing we did on our platform: we
didn't add the '-1' to the platform device ranges, so there was no
need for the '+1'.

I guess it's The Good Thing to do to add a '+1' here, I'll take care
of changing our platform specific bits to match this.

Thanks for pointing that out.

Let me know if I should resubmit the patch.

Thibaut VARENE


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_ide95&alloc_id\x14396&op=click