Re: Re: [PATCH 5/5] s1d13xxxfb: Add support for Epson S1D13806 FB

["Antonino A. Daplas" <adaplas@hotpop.com>]

On Tuesday 15 March 2005 10:40, Andrew Morton wrote:
> "Antonino A. Daplas" <adaplas@hotpop.com> wrote:
> >   Attached to that mail is a patch adding support for Epson S1D13806
> >    framebuffer device.
> >
> >    That driver is intended to be easily used with other S1D13xxx devices,
> >    hopefully by splitting the header file and changing a few defines.
> > Since I haven't got the hardware to test that, though, I can only assert
> > that it works with S1D13806.
> >
> >    This driver has been succesfully tested on ARM embedded boards and
> >    reported working on SH architecture as well.
> >
> >    Since this is my first framebuffer driver, I would welcome any
> >    suggestion/comment about it :)
> >
> >    This driver has been built on top of some preliminary ARM specific
> > work by Ben Dooks, and adapted from existing code (as stated in the
> > header of s1d13xxxfb.c).
> >
> >  Signed-off-by: Thibaut VARENE <varenet@parisc-linux.org>
> >  Signed-off-by: Antonino Daplas <adaplas@pol.net>
>
> I've been going around editing From: lines recently, in cases where it's
> obvious.  I did so with this patch - please let me know if that is
> inappropariate.

No, this is okay.

>
>
> So the patch will hit bk as:
>
> From: Thibaut VARENE <varenet@parisc-linux.org>
> Signed-off-by: Thibaut VARENE <varenet@parisc-linux.org>
> Signed-off-by: Antonino Daplas <adaplas@pol.net>
> Signed-off-by: Andrew Morton <akpm@osdl.org>
>
>
> So
>
> a) Thibaut will be identified in the bk logs as the author
>
> b) His name will appear in the short-form changelogs, etc.
>
> c) The Signed-off-by: line will note that Tony and I also handled this
>    patch, and possibly made small changes to it.
>
> I do this so that contributors get suitable credit, and so that bug
> reporters have a better chance of finding who to email on the first
> attempt.
>

With the patches I send you, the first one in the signed-off line is the
original contributor of the patch and the changelog. If the original
contributor did not sign-off, I add a 'From: <author>' with or without the
e-mail address at the very beginning of the changelog.

Anyway, would you like to me to follow the format below to make it
easier for you?

> From: Thibaut VARENE <varenet@parisc-linux.org>
> Signed-off-by: Thibaut VARENE <varenet@parisc-linux.org>
> Signed-off-by: Antonino Daplas <adaplas@pol.net>
> Signed-off-by: Andrew Morton <akpm@osdl.org>

Tony




-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click