From: "Antonino A. Daplas" <adaplas@hotpop.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Brad Boyer <flar@allandria.com>
Cc: Tamas K Papp <tpapp@Princeton.EDU>,
Debian PPC <debian-powerpc@lists.debian.org>,
Linux Fbdev development list
<linux-fbdev-devel@lists.sourceforge.net>
Subject: Re: [Linux-fbdev-devel] Re: open messes up the screen
Date: Fri, 18 Mar 2005 05:05:09 +0800 [thread overview]
Message-ID: <200503180505.10779.adaplas@hotpop.com> (raw)
In-Reply-To: <1110949031.14171.137.camel@gaston>
On Wednesday 16 March 2005 12:57, Benjamin Herrenschmidt wrote:
> > Well, open is really openvt. It fiddles around with the console to
> > start up a program on a new virtual console. X doesn't always like
> > that, but it should work better than that. The vt change should
> > trigger X to properly cleanup the screen before the switch. I'd
> > say file a bug.
>
> It's not a VT change issue. It's an old bug of the fbcon code that
> causes opening a VT to reset the palette on the current fb even when not
> in front.
>
Can you try this patch?
diff -Nru a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c
--- a/drivers/video/console/fbcon.c 2005-03-16 07:39:24 +08:00
+++ b/drivers/video/console/fbcon.c 2005-03-18 04:58:31 +08:00
@@ -2331,6 +2331,9 @@
if (fbcon_is_inactive(vc, info))
return -EINVAL;
+ if (!CON_IS_VISIBLE(vc))
+ return 0;
+
depth = fb_get_color_depth(&info->var);
if (depth > 3) {
for (i = j = 0; i < 16; i++) {
prev parent reply other threads:[~2005-03-17 21:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20050315150934.GA6687@tpapp.student.princeton.edu>
[not found] ` <20050315173827.GA10301@pants.nu>
2005-03-16 4:57 ` open messes up the screen Benjamin Herrenschmidt
2005-03-17 21:05 ` Antonino A. Daplas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200503180505.10779.adaplas@hotpop.com \
--to=adaplas@hotpop.com \
--cc=adaplas@pol.net \
--cc=benh@kernel.crashing.org \
--cc=debian-powerpc@lists.debian.org \
--cc=flar@allandria.com \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=tpapp@Princeton.EDU \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).