* Re: open messes up the screen
[not found] ` <20050315173827.GA10301@pants.nu>
@ 2005-03-16 4:57 ` Benjamin Herrenschmidt
2005-03-17 21:05 ` [Linux-fbdev-devel] " Antonino A. Daplas
0 siblings, 1 reply; 2+ messages in thread
From: Benjamin Herrenschmidt @ 2005-03-16 4:57 UTC (permalink / raw)
To: Brad Boyer; +Cc: Tamas K Papp, Debian PPC, Linux Fbdev development list
> Well, open is really openvt. It fiddles around with the console to
> start up a program on a new virtual console. X doesn't always like
> that, but it should work better than that. The vt change should
> trigger X to properly cleanup the screen before the switch. I'd
> say file a bug.
>
It's not a VT change issue. It's an old bug of the fbcon code that
causes opening a VT to reset the palette on the current fb even when not
in front.
Ben.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Linux-fbdev-devel] Re: open messes up the screen
2005-03-16 4:57 ` open messes up the screen Benjamin Herrenschmidt
@ 2005-03-17 21:05 ` Antonino A. Daplas
0 siblings, 0 replies; 2+ messages in thread
From: Antonino A. Daplas @ 2005-03-17 21:05 UTC (permalink / raw)
To: Benjamin Herrenschmidt, Brad Boyer
Cc: Tamas K Papp, Debian PPC, Linux Fbdev development list
On Wednesday 16 March 2005 12:57, Benjamin Herrenschmidt wrote:
> > Well, open is really openvt. It fiddles around with the console to
> > start up a program on a new virtual console. X doesn't always like
> > that, but it should work better than that. The vt change should
> > trigger X to properly cleanup the screen before the switch. I'd
> > say file a bug.
>
> It's not a VT change issue. It's an old bug of the fbcon code that
> causes opening a VT to reset the palette on the current fb even when not
> in front.
>
Can you try this patch?
diff -Nru a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c
--- a/drivers/video/console/fbcon.c 2005-03-16 07:39:24 +08:00
+++ b/drivers/video/console/fbcon.c 2005-03-18 04:58:31 +08:00
@@ -2331,6 +2331,9 @@
if (fbcon_is_inactive(vc, info))
return -EINVAL;
+ if (!CON_IS_VISIBLE(vc))
+ return 0;
+
depth = fb_get_color_depth(&info->var);
if (depth > 3) {
for (i = j = 0; i < 16; i++) {
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-03-17 21:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20050315150934.GA6687@tpapp.student.princeton.edu>
[not found] ` <20050315173827.GA10301@pants.nu>
2005-03-16 4:57 ` open messes up the screen Benjamin Herrenschmidt
2005-03-17 21:05 ` [Linux-fbdev-devel] " Antonino A. Daplas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).