[PATCH] print an explanation why i810 fb doesn't come up

[PATCH] print an explanation why i810 fb doesn't come up

[Denis Vlasenko]

[-- Attachment #1: Type: text/plain, Size: 185 bytes --]

I've spent silly amonunt of time trying to use i810 fb on my new spiffy
flat panel. This patch will hopefully help other poor souls.

Patch also fixes module parameter comments.
--
vda

[-- Attachment #2: i810_main.c.diff --]
[-- Type: text/x-diff, Size: 1202 bytes --]

--- linux-2.6.11.src/drivers/video/i810/i810_main.c.orig	Thu Mar  3 09:30:58 2005
+++ linux-2.6.11.src/drivers/video/i810/i810_main.c	Mon Mar 28 15:04:58 2005
@@ -999,8 +999,14 @@ static int i810_check_params(struct fb_v
 	info->monspecs.dclkmin = 15000000;
 
 	if (fb_validate_mode(var, info)) {
-		if (fb_get_mode(FB_MAXTIMINGS, 0, var, info))
+		if (fb_get_mode(FB_MAXTIMINGS, 0, var, info)) {
+			int default_sync = (hsync1-HFMIN)|(hsync2-HFMAX)
+					    |(vsync1-VFMIN)|(vsync2-VFMAX);
+			printk("i810fb: invalid video mode%s\n",
+			    default_sync ? "" : 
+			    ". Specifying vsyncN/hsyncN parameters may help");
 			return -EINVAL;
+		}
 	}
 	
 	var->xres = xres;
@@ -2020,10 +2026,10 @@ MODULE_PARM_DESC(vyres, "Virtual vertica
 		 " (default = 480)");
 module_param(hsync1, int, 0);
 MODULE_PARM_DESC(hsync1, "Minimum horizontal frequency of monitor in KHz"
-		 " (default = 31)");
+		 " (default = 29)");
 module_param(hsync2, int, 0);
 MODULE_PARM_DESC(hsync2, "Maximum horizontal frequency of monitor in KHz"
-		 " (default = 31)");
+		 " (default = 30)");
 module_param(vsync1, int, 0);
 MODULE_PARM_DESC(vsync1, "Minimum vertical frequency of monitor in Hz"
 		 " (default = 50)");

Re: [PATCH] print an explanation why i810 fb doesn't come up

[Antonino A. Daplas]

On Monday 28 March 2005 20:30, Denis Vlasenko wrote:
> I've spent silly amonunt of time trying to use i810 fb on my new spiffy
> flat panel. This patch will hopefully help other poor souls.
>
> Patch also fixes module parameter comments.

Thanks, should help.

Tony




-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click