From: Pavel Machek <pavel@suse.cz>
To: Nigel Cunningham <ncunningham@cyclades.com>
Cc: Andrew Morton <akpm@osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
USB development list <linux-usb-devel@lists.sourceforge.net>,
FrameBuffer Devel <linux-fbdev-devel@lists.sourceforge.net>
Subject: Re: [PATCH] pm_message_t corrections still missing from 2.6.12-rc2
Date: Fri, 8 Apr 2005 14:31:44 +0200 [thread overview]
Message-ID: <20050408123144.GB1379@elf.ucw.cz> (raw)
In-Reply-To: <1112961860.3757.755.camel@desktop.cunningham.myip.net.au>
Hi!
> Here, for your consideration, are fixups I still have in my tree after
> updating to rc2.
>
> (USB & Framebuffer lists copied because a reasonable number apply
> there).
>
> Regards,
>
> Nigel
>
> diff -ruNp 840-combined-pm_message_t-patch.patch-old/drivers/base/power/resume.c 840-combined-pm_message_t-patch.patch-new/drivers/base/power/resume.c
> --- 840-combined-pm_message_t-patch.patch-old/drivers/base/power/resume.c 2004-12-10 14:26:51.000000000 +1100
> +++ 840-combined-pm_message_t-patch.patch-new/drivers/base/power/resume.c 2005-04-08 13:41:41.000000000 +1000
> @@ -41,7 +41,7 @@ void dpm_resume(void)
> list_add_tail(entry, &dpm_active);
>
> up(&dpm_list_sem);
> - if (!dev->power.prev_state)
> + if (!dev->power.prev_state.event)
> resume_device(dev);
> down(&dpm_list_sem);
> put_device(dev);
We do not want these to go anywhere for now. These depend on switching
pm_message_t to struct, and that's 2.6.13 material.
Except that, there are some good fixes (u32->pm_message_t), but they
should be in -mm kernel already.
...except USB. I'm talking with David Brownell about those.
Pavel
--
Boycott Kodak -- for their patent abuse against Java.
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
linux-usb-devel@lists.sourceforge.net
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
prev parent reply other threads:[~2005-04-08 12:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-08 12:04 [PATCH] pm_message_t corrections still missing from 2.6.12-rc2 Nigel Cunningham
2005-04-08 12:31 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050408123144.GB1379@elf.ucw.cz \
--to=pavel@suse.cz \
--cc=akpm@osdl.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=ncunningham@cyclades.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox