Re: Re: [PATCH 1/6] nvidiafb: ioremap and i2c fixes

["Antonino A. Daplas" <adaplas@hotpop.com>]

On Sunday 24 April 2005 08:40, Andrew Morton wrote:
> "Antonino A. Daplas" <adaplas@hotpop.com> wrote:
> > - Add 'vram' option to specify amount of video RAM to remap
> >  - Limit remap size to 128 MIB
>
> Am I right in believing that if someone has a 256MB card and doesn't know
> about the `vram' option, their card will fail to work, because the 128MB
> vmalloc() will fail?
>

I thought that a 128MiB vmalloc will work.

> If so, that seems a bit user-hostile to me.  Perhaps we should make it
> 64MB?

Okay, dropping maximum to 64 MiB.

From: Antonino Daplas <adaplas@pol.net>
Signed-off-by: Antonino Daplas <adaplas@pol.net>

 nvidia.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff -Nru a/drivers/video/nvidia/nvidia.c b/drivers/video/nvidia/nvidia.c
--- a/drivers/video/nvidia/nvidia.c	2005-04-16 11:54:44 +08:00
+++ b/drivers/video/nvidia/nvidia.c	2005-04-25 10:39:45 +08:00
@@ -1511,9 +1511,9 @@
 	if (vram && vram * 1024 * 1024 < par->FbMapSize)
 		par->FbMapSize = vram * 1024 * 1024;
 
-	/* Limit amount of vram to 128 MB */
-	if (par->FbMapSize > 128 * 1024 * 1024)
-		par->FbMapSize = 128 * 1024 * 1024;
+	/* Limit amount of vram to 64 MB */
+	if (par->FbMapSize > 64 * 1024 * 1024)
+		par->FbMapSize = 64 * 1024 * 1024;
 
 	par->FbUsableSize = par->FbMapSize - (128 * 1024);
 	par->ScratchBufferSize = (par->Architecture < NV_ARCH_10) ? 8 * 1024 :




-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click