From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Antonino A. Daplas" Subject: Re: Re: [PATCH 1/6] nvidiafb: ioremap and i2c fixes Date: Mon, 25 Apr 2005 11:21:20 +0800 Message-ID: <200504251121.20530.adaplas@hotpop.com> References: <200504161313.25574.adaplas@hotpop.com> <20050423174013.3006852f.akpm@osdl.org> Reply-To: linux-fbdev-devel@lists.sourceforge.net Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: Received: from sc8-sf-mx2-b.sourceforge.net ([10.3.1.12] helo=sc8-sf-mx2.sourceforge.net) by sc8-sf-list1.sourceforge.net with esmtp (Exim 4.30) id 1DPuDp-0005Fr-DC for linux-fbdev-devel@lists.sourceforge.net; Sun, 24 Apr 2005 20:25:21 -0700 Received: from smtp-out.hotpop.com ([38.113.3.71]) by sc8-sf-mx2.sourceforge.net with esmtp (Exim 4.41) id 1DPuDn-0003mR-OU for linux-fbdev-devel@lists.sourceforge.net; Sun, 24 Apr 2005 20:25:21 -0700 Received: from hotpop.com (kubrick.hotpop.com [38.113.3.103]) by smtp-out.hotpop.com (Postfix) with SMTP id 5D305157F5CD for ; Mon, 25 Apr 2005 03:24:10 +0000 (UTC) In-Reply-To: <20050423174013.3006852f.akpm@osdl.org> Content-Disposition: inline Sender: linux-fbdev-devel-admin@lists.sourceforge.net Errors-To: linux-fbdev-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Id: List-Post: List-Help: List-Subscribe: , List-Archive: Content-Type: text/plain; charset="us-ascii" To: Andrew Morton , adaplas@pol.net Cc: linux-fbdev-devel@lists.sourceforge.net On Sunday 24 April 2005 08:40, Andrew Morton wrote: > "Antonino A. Daplas" wrote: > > - Add 'vram' option to specify amount of video RAM to remap > > - Limit remap size to 128 MIB > > Am I right in believing that if someone has a 256MB card and doesn't know > about the `vram' option, their card will fail to work, because the 128MB > vmalloc() will fail? > I thought that a 128MiB vmalloc will work. > If so, that seems a bit user-hostile to me. Perhaps we should make it > 64MB? Okay, dropping maximum to 64 MiB. From: Antonino Daplas Signed-off-by: Antonino Daplas nvidia.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff -Nru a/drivers/video/nvidia/nvidia.c b/drivers/video/nvidia/nvidia.c --- a/drivers/video/nvidia/nvidia.c 2005-04-16 11:54:44 +08:00 +++ b/drivers/video/nvidia/nvidia.c 2005-04-25 10:39:45 +08:00 @@ -1511,9 +1511,9 @@ if (vram && vram * 1024 * 1024 < par->FbMapSize) par->FbMapSize = vram * 1024 * 1024; - /* Limit amount of vram to 128 MB */ - if (par->FbMapSize > 128 * 1024 * 1024) - par->FbMapSize = 128 * 1024 * 1024; + /* Limit amount of vram to 64 MB */ + if (par->FbMapSize > 64 * 1024 * 1024) + par->FbMapSize = 64 * 1024 * 1024; par->FbUsableSize = par->FbMapSize - (128 * 1024); par->ScratchBufferSize = (par->Architecture < NV_ARCH_10) ? 8 * 1024 : ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click