Three fbdev bug fixes

Three fbdev bug fixes

[Jon Smirl]

[-- Attachment #1: Type: text/plain, Size: 432 bytes --]

#1) fbdev is missing unregister_chrdev(FB_MAJOR, "fb");
#2) rounding issues can make an acceptable mode fail
added  hfreq = (hfreq + 500) / 1000 * 1000;
#3) Benh has picked this up. radeonfb is not deleting it's sysfs attributes
  sysfs_remove_bin_file(&rinfo->pdev->dev.kobj, &edid1_attr);
  sysfs_remove_bin_file(&rinfo->pdev->dev.kobj, &edid2_attr);

All three are in the attachment

-- 
Jon Smirl
jonsmirl@gmail.com

[-- Attachment #2: patch --]
[-- Type: application/octet-stream, Size: 1130 bytes --]

===== drivers/video/fbmem.c 1.160 vs edited =====
--- 1.160/drivers/video/fbmem.c	2005-03-31 06:06:52 -05:00
+++ edited/drivers/video/fbmem.c	2005-04-25 01:33:57 -04:00
@@ -1211,6 +1211,7 @@
 fbmem_exit(void)
 {
 	class_simple_destroy(fb_class);
+	unregister_chrdev(FB_MAJOR, "fb");
 }
 
 module_exit(fbmem_exit);
===== drivers/video/fbmon.c 1.22 vs edited =====
--- 1.22/drivers/video/fbmon.c	2005-03-31 06:06:52 -05:00
+++ edited/drivers/video/fbmon.c	2005-04-25 13:58:13 -04:00
@@ -1242,6 +1242,8 @@
 		vtotal *= 2;
 
 	hfreq = pixclock/htotal;
+	hfreq = (hfreq + 500) / 1000 * 1000;
+	
 	vfreq = hfreq/vtotal;
 
 	return (vfreq < vfmin || vfreq > vfmax || 
===== drivers/video/aty/radeon_base.c 1.48 vs edited =====
--- 1.48/drivers/video/aty/radeon_base.c	2005-03-31 06:06:52 -05:00
+++ edited/drivers/video/aty/radeon_base.c	2005-04-28 12:56:55 -04:00
@@ -2452,6 +2452,11 @@
  
 	radeonfb_pm_exit(rinfo);
 
+	if (rinfo->mon1_EDID)
+		sysfs_remove_bin_file(&rinfo->pdev->dev.kobj, &edid1_attr);
+	if (rinfo->mon2_EDID)
+		sysfs_remove_bin_file(&rinfo->pdev->dev.kobj, &edid2_attr);
+
 #if 0
 	/* restore original state
 	 * 

Re: Three fbdev bug fixes

[Antonino A. Daplas]

On Friday 29 April 2005 01:02, Jon Smirl wrote:
> #1) fbdev is missing unregister_chrdev(FB_MAJOR, "fb");
> #2) rounding issues can make an acceptable mode fail
> added  hfreq = (hfreq + 500) / 1000 * 1000;

I already picked up 1 and 2.

Tony




-------------------------------------------------------
SF.Net email is sponsored by: Tell us your software development plans!
Take this survey and enter to win a one-year sub to SourceForge.net
Plus IDC's 2005 look-ahead and a copy of this survey
Click here to start!  http://www.idcswdc.com/cgi-bin/survey?id=105hix