From: Luca <kronos@people.it>
To: linux-fbdev-devel@lists.sourceforge.net
Cc: Patrick McManus <mcmanus@ducksong.com>
Subject: Re: unpriv'd 2.6.12-rc4 oops reading /sys/module/intelfb/parameters/*
Date: Fri, 13 May 2005 21:14:20 +0200 [thread overview]
Message-ID: <20050513191420.GB7891@dreamland.darkstar.lan> (raw)
In-Reply-To: <1115995414.5648.64.camel@mcmanus.datapower.com>
Il Fri, May 13, 2005 at 10:43:34AM -0400, patrick mcmanus ha scritto:
> Signed-off-by: Patrick McManus <mcmanus@ducksong.com>
>
> Index: drivers/video/intelfb/intelfbdrv.c
> ===================================================================
> --- b44e6db42c986f858d2487a6a41ee0cbdd2cf670/drivers/video/intelfb/intelfbdrv.c (mode:100644 sha1:549e229392604359f46ed629d916b4ea89674226)
> +++ uncommitted/drivers/video/intelfb/intelfbdrv.c (mode:100644)
> @@ -228,17 +228,17 @@
> MODULE_LICENSE("Dual BSD/GPL");
> MODULE_DEVICE_TABLE(pci, intelfb_pci_table);
>
> -static int accel __initdata = 1;
> -static int vram __initdata = 4;
> -static int hwcursor __initdata = 1;
> -static int mtrr __initdata = 1;
> -static int fixed __initdata = 0;
> -static int noinit __initdata = 0;
> -static int noregister __initdata = 0;
> -static int probeonly __initdata = 0;
> -static int idonly __initdata = 0;
> -static int bailearly __initdata = 0;
> -static char *mode __initdata = NULL;
> +static int accel = 1;
> +static int vram = 4;
> +static int hwcursor = 1;
> +static int mtrr = 1;
> +static int fixed = 0;
> +static int noinit = 0;
> +static int noregister = 0;
> +static int probeonly = 0;
> +static int idonly = 0;
> +static int bailearly = 0;
> +static char *mode = NULL;
Hi,
while you are at it, initializing static vars to 0 (or NULL) is
superfluous and take them out of BSS.
Luca
--
Home: http://kronoz.cjb.net
"L'amore consiste nell'essere cretini insieme." -- P. Valery
-------------------------------------------------------
This SF.Net email is sponsored by Oracle Space Sweepstakes
Want to be the first software developer in space?
Enter now for the Oracle Space Sweepstakes!
http://ads.osdn.com/?ad_id=7393&alloc_id=16281&op=click
prev parent reply other threads:[~2005-05-13 19:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-13 14:43 unpriv'd 2.6.12-rc4 oops reading /sys/module/intelfb/parameters/* patrick mcmanus
2005-05-13 19:14 ` Luca [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050513191420.GB7891@dreamland.darkstar.lan \
--to=kronos@people.it \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=mcmanus@ducksong.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox