Linux Framebuffer Layer development
 help / color / mirror / Atom feed
From: akpm@osdl.org
To: kambarov@berkeley.edu, linux-fbdev-devel@lists.sourceforge.net,
	zkambarov@coverity.com, mm-commits@vger.kernel.org
Subject: coverity-fbsysfs-fix-null-pointer-check.patch added to -mm tree
Date: Thu, 30 Jun 2005 22:53:09 -0700	[thread overview]
Message-ID: <200507010553.j615rbmw022839@shell0.pdx.osdl.net> (raw)


The patch titled

     coverity: fix fbsysfs null pointer check

has been added to the -mm tree.  Its filename is

     coverity-fbsysfs-fix-null-pointer-check.patch

Patches currently in -mm which might be from kambarov@berkeley.edu are

coverity-fbsysfs-fix-null-pointer-check.patch



From: "KAMBAROV, ZAUR" <kambarov@berkeley.edu>

Correctly test for a null pointer before going and dereferencing it.

This defect was found automatically by Coverity Prevent, a static analysis
tool.

Signed-off-by: Zaur Kambarov <zkambarov@coverity.com>
Cc: <linux-fbdev-devel@lists.sourceforge.net>
Signed-off-by: Andrew Morton <akpm@osdl.org>
---

 drivers/video/fbsysfs.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -puN drivers/video/fbsysfs.c~coverity-fbsysfs-fix-null-pointer-check drivers/video/fbsysfs.c
--- devel/drivers/video/fbsysfs.c~coverity-fbsysfs-fix-null-pointer-check	2005-06-30 22:52:31.000000000 -0700
+++ devel-akpm/drivers/video/fbsysfs.c	2005-06-30 22:52:31.000000000 -0700
@@ -256,7 +256,7 @@ static ssize_t show_cmap(struct class_de
 	unsigned int offset = 0, i;
 
 	if (!fb_info->cmap.red || !fb_info->cmap.blue ||
-	    fb_info->cmap.green || fb_info->cmap.transp)
+	    !fb_info->cmap.green || !fb_info->cmap.transp)
 		return -EINVAL;
 
 	for (i = 0; i < fb_info->cmap.len; i++) {
_


-------------------------------------------------------
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
from IBM. Find simple to follow Roadmaps, straightforward articles,
informative Webcasts and more! Get everything you need to get up to
speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click

             reply	other threads:[~2005-07-01  5:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-01  5:53 akpm [this message]
2005-07-01 23:53 ` coverity-fbsysfs-fix-null-pointer-check.patch added to -mm tree James Simmons

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200507010553.j615rbmw022839@shell0.pdx.osdl.net \
    --to=akpm@osdl.org \
    --cc=kambarov@berkeley.edu \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    --cc=mm-commits@vger.kernel.org \
    --cc=zkambarov@coverity.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox