linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH][fbcon] Don't repaint the cursor when it is disabled.
@ 2005-07-17 12:00 Michal Januszewski
  0 siblings, 0 replies; only message in thread
From: Michal Januszewski @ 2005-07-17 12:00 UTC (permalink / raw)
  To: linux-fbdev-devel; +Cc: linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1078 bytes --]

Hi,

Currently even when the cursor is disabled (`setterm -cursor off`), it
is still repainted as a black rectangle the size of a single char. This
can be seen, for example, by chvt'ing to a free tty, disabling the
cursor and doing `dd if=/dev/urandom of=/dev/fb0`.

The patch changes this behaviour by avoiding painting anything when the
cursor is disabled.

Signed-off-by: Michal Januszewski <spock@gentoo.org>
---

diff -Nupr linux-2.6.12-orig/drivers/video/console/fbcon.c linux-2.6.12/drivers/video/console/fbcon.c
--- linux-2.6.12-orig/drivers/video/console/fbcon.c	2005-06-17 21:48:29.000000000 +0200
+++ linux-2.6.12/drivers/video/console/fbcon.c	2005-07-17 13:32:00.000000000 +0200
@@ -276,7 +276,8 @@ static void fb_flashcursor(void *private
 
 	if (!vc || !CON_IS_VISIBLE(vc) ||
 	    fbcon_is_inactive(vc, info) ||
- 	    registered_fb[con2fb_map[vc->vc_num]] != info)
+ 	    registered_fb[con2fb_map[vc->vc_num]] != info ||
+	    vc_cons[ops->currcon].d->vc_deccm != 1)
 		return;
 	acquire_console_sem();
 	p = &fb_display[vc->vc_num];


[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2005-07-17 12:00 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-07-17 12:00 [PATCH][fbcon] Don't repaint the cursor when it is disabled Michal Januszewski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).